Skip to content

Intw26 file upload poc#258

Draft
gavxue wants to merge 3 commits intostagingfrom
INTW26-file-upload-poc
Draft

Intw26 file upload poc#258
gavxue wants to merge 3 commits intostagingfrom
INTW26-file-upload-poc

Conversation

@gavxue
Copy link
Copy Markdown
Collaborator

@gavxue gavxue commented Mar 21, 2026

Notion ticket link

Build file upload POC

Implementation description

  • Added a reusable UploadFile component with client-side file validation for PDF/JPEG/PNG, selected-file preview, and upload status/error feedback.
  • Added GraphQL upload support via multipart FormData helper and a new createFirebaseFile mutation.
  • Added a test page at /review/uploadFile to manually verify end-to-end upload behavior in the app UI.

Steps to test

  1. Start the app (with associated backend PR [INTW26] File upload POC website-bp-be#129) and go to /review/uploadFile.
  2. Select a valid file (PDF/JPEG/PNG) and click Upload File.
  3. Confirm success message appears and the input resets after upload.
  4. Try an invalid type (for example .txt) and confirm validation error appears.
  5. (Optional) Simulate backend failure and confirm upload error state is shown.

What should reviewers focus on?

  • GraphQL mutation
  • File validation and UX states (idle/uploading/success/error), including edge cases.

Checklist

  • My PR name is descriptive and in imperative tense
  • My commit messages are descriptive and in imperative tense. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
  • I have run the appropriate linter(s)
  • I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR

@gavxue gavxue self-assigned this Mar 21, 2026
@gavxue gavxue marked this pull request as ready for review March 21, 2026 04:51
@gavxue gavxue requested a review from mxc-maggiechen March 24, 2026 21:43
@mxc-maggiechen mxc-maggiechen requested a review from SaqAsh March 26, 2026 01:47
@SaqAsh SaqAsh marked this pull request as draft May 5, 2026 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant