Skip to content

[INTF26] Rebuilds review UI revamp on staging#260

Merged
SaqAsh merged 21 commits intostagingfrom
sparsh/INTF26-review-UI-revamp
May 8, 2026
Merged

[INTF26] Rebuilds review UI revamp on staging#260
SaqAsh merged 21 commits intostagingfrom
sparsh/INTF26-review-UI-revamp

Conversation

@OpsEclipse
Copy link
Copy Markdown
Collaborator

@OpsEclipse OpsEclipse commented Apr 4, 2026

Notion ticket link

Revamp Review Basic Info Page Layout

Implementation description

  • Rebuilds the review UI revamp on top of the latest staging branch so the PR keeps the intended design changes without carrying the old conflict-heavy history forward.
  • Restores the revamped review experience across the basic info page, scored review stages, final scoring screen, and submit-success screen using review-specific layouts and updated answer/rubric presentation.
  • Adds safer review parsing and score progression guardrails so reviewers cannot skip ahead through required scoring stages from either the header stepper or footer controls.

Steps to test

  1. Run ./node_modules/.bin/eslint on the touched review files and confirm it passes.
  2. Run yarn lint:tsc and note the current failures in components/admin/ReviewTable.tsx, components/admin/ReviewTableColumn.tsx, components/interview/shared/InterviewProgressContext.tsx, and components/interview/shared/types.ts, which are outside this PR diff.
  3. Run yarn dev, open a valid review link, and verify the revamped UI across the basic info page, PFSG, team player, drive to learn, skill, final scoring, and submit-success states.
  4. Try advancing without entering a score and confirm the flow blocks progress from both the header and footer navigation until the required stage is scored.
  5. Open /review without a valid reviewId and confirm the invalid-link state is shown.

What should reviewers focus on?

  • Whether the rebuilt review-specific layouts preserve the intended INTF26 revamp while fitting cleanly on top of the newer staging layout work.
  • The new shared score/progress helpers in the review flow, especially header navigation limits and final submission gating.
  • The refreshed final scoring and submit-success UI.

Checklist

  • My PR name is descriptive and in imperative tense
  • My commit messages are descriptive and in imperative tense. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
  • I have run the appropriate linter(s)
  • I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR

@OpsEclipse OpsEclipse force-pushed the sparsh/INTF26-review-UI-revamp branch from c3adaea to 51b0d29 Compare April 4, 2026 22:28
@OpsEclipse OpsEclipse changed the title [INTF26] Revamps review stage layouts and scoring progression [INTF26] Rebuilds review UI revamp on staging Apr 4, 2026
Comment thread components/review/stages/ReviewInfoStage.tsx Outdated
Comment thread components/review/stages/ReviewInfoStage.tsx Outdated
@SaqAsh SaqAsh self-assigned this May 5, 2026
@SaqAsh SaqAsh force-pushed the sparsh/INTF26-review-UI-revamp branch from 949aa99 to 66a8ac6 Compare May 7, 2026 03:44
OpsEclipse and others added 12 commits May 7, 2026 11:19
Reapply the review layout refresh on top of the current staging branch instead of carrying the conflicted branch history forward.

Restore the revamp's staged layouts, safer review parsing, progress gating, and updated success flow while keeping the newer shared platform work from staging.
Tighten spacing across the review screens and show the applicant timezone in the basic information panel

Remove the extra divider so the section matches the updated layout
refresh the first review screen to match the newer shared review UI pieces and keep the scope on the basic information page

this also keeps the short-answer parsing used by the page and the small review page cleanups that came along with the rebase state
@SaqAsh SaqAsh force-pushed the sparsh/INTF26-review-UI-revamp branch from 09a7091 to ed7493e Compare May 7, 2026 15:21
Comment thread components/review/shared/reviewUtils.ts
Comment thread pages/review/index.tsx

await reportReviewConflict(
applicantRecordId,
Number(authenticatedUser.id),
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need the number cast here, when retrieving the ID from local host storage, the id gets typed as string during run time, even though at compile time it is typed as number

Comment thread pages/review/index.tsx
Comment thread components/review/stages/ReviewTeamPlayerStage.tsx
Comment thread components/review/stages/ReviewInfoStage.tsx
@SaqAsh SaqAsh merged commit 2d1ab9d into staging May 8, 2026
@SaqAsh SaqAsh deleted the sparsh/INTF26-review-UI-revamp branch May 8, 2026 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants