[INTF26] Rebuilds review UI revamp on staging#260
Merged
Conversation
c3adaea to
51b0d29
Compare
SaqAsh
requested changes
May 5, 2026
SaqAsh
approved these changes
May 7, 2026
949aa99 to
66a8ac6
Compare
Reapply the review layout refresh on top of the current staging branch instead of carrying the conflicted branch history forward. Restore the revamp's staged layouts, safer review parsing, progress gating, and updated success flow while keeping the newer shared platform work from staging.
Tighten spacing across the review screens and show the applicant timezone in the basic information panel Remove the extra divider so the section matches the updated layout
This reverts commit 1f2437b.
This reverts commit 51b0d29.
refresh the first review screen to match the newer shared review UI pieces and keep the scope on the basic information page this also keeps the short-answer parsing used by the page and the small review page cleanups that came along with the rebase state
09a7091 to
ed7493e
Compare
SaqAsh
reviewed
May 7, 2026
|
|
||
| await reportReviewConflict( | ||
| applicantRecordId, | ||
| Number(authenticatedUser.id), |
There was a problem hiding this comment.
I think we need the number cast here, when retrieving the ID from local host storage, the id gets typed as string during run time, even though at compile time it is typed as number
mxc-maggiechen
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notion ticket link
Revamp Review Basic Info Page Layout
Implementation description
stagingbranch so the PR keeps the intended design changes without carrying the old conflict-heavy history forward.Steps to test
./node_modules/.bin/eslinton the touched review files and confirm it passes.yarn lint:tscand note the current failures incomponents/admin/ReviewTable.tsx,components/admin/ReviewTableColumn.tsx,components/interview/shared/InterviewProgressContext.tsx, andcomponents/interview/shared/types.ts, which are outside this PR diff.yarn dev, open a valid review link, and verify the revamped UI across the basic info page, PFSG, team player, drive to learn, skill, final scoring, and submit-success states./reviewwithout a validreviewIdand confirm the invalid-link state is shown.What should reviewers focus on?
staginglayout work.Checklist