Pranay Code Review #30
Open
mundrapranay wants to merge 35 commits intomasterfrom
Open
Conversation
In order to import it, must be using Python 2.7 to match what is in Boost's project-config.jam. Segfaults when exiting Python.
Member
BrandonHaynes
left a comment
BrandonHaynes
left a comment
There was a problem hiding this comment.
Nice job, just some minor code cleanup left to go.
| include_directories(${LIGHTDB_CORE_INCLUDE_DIRS} ${Boost_INCLUDE_DIRS} ${Python2_INCLUDE_DIRS}) | ||
|
|
||
| # Include ipp | ||
| include_directories(/opt/intel/ipp/include) |
| boost::python::call<void>(callable_, swap); | ||
|
|
||
| // RGB -> NV12 | ||
| CHECK_EQ(ippiRGBToYCbCr420_8u_C3P2R(rgb_.data(), channels * frame->width(), (Ipp8u*)y_out, frame->width(), (Ipp8u*)uv_out, frame->width(), size), ippStsNoErr); |
| auto uv_out = y_out + frameSize_; | ||
|
|
||
| // NV12 -> RGB | ||
| CHECK_EQ(ippiYCbCr420ToRGB_8u_P2C3R((Ipp8u*)y_in, frame->width(), (Ipp8u*)uv_in, frame->width(), rgb_.data(), channels * frame->width(), size), ippStsNoErr); |
| string(REPLACE ";" "|" LIGHTDB_INCLUDES_STRING "${LIGHTDB_INCLUDES}") | ||
|
|
||
| foreach(LIGHTDB_PLUGIN_DIR ${LIGHTDB_PLUGIN_DIRS}) | ||
| message("Lightdb plugin dir: ${LIGHTDB_PLUGIN_DIR}") |
| EXPECT_EQ(remove(Resources.out.hevc), 0); | ||
| } | ||
|
|
||
| TEST_F(SelectionTestFixture, testPythonQuery) { |
| .Map(lightdb::Greyscale) | ||
| .Encode() | ||
| .Save(Resources.out.hevc); | ||
| .Save("/home/maureen/grey_test.hevc"); |
BrandonHaynes
approved these changes
Aug 10, 2020
Member
BrandonHaynes
left a comment
BrandonHaynes
left a comment
There was a problem hiding this comment.
Super minor nits and this is ready to go.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.