urdf arm description #173
Open
urdf arm description #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
need to add the package to ci.yaml to get it to run the checks |
wmmc88
reviewed
Jan 13, 2022
...ver_arm/uwrt_mars_rover_arm_description/uwrt_mars_rover_arm_description/urdf/arm_params.yaml
Show resolved
Hide resolved
wmmc88
reviewed
Jan 13, 2022
Comment on lines
+57
to
+61
| <!-- default inertia --> | ||
| <xacro:macro name="default_inertia"> | ||
| <inertia ixx="0.4" ixy="0.0" ixz="0.0" iyy="0.4" iyz="0.0" izz="0.2"/> | ||
| </xacro:macro> | ||
|
|
There was a problem hiding this comment.
we should probably consolidate the shared macros into some top level package
There was a problem hiding this comment.
would that include the geometry macros too?
There was a problem hiding this comment.
I don't think so. Just things that are shared between this xacro and my drivetrain xacro
There was a problem hiding this comment.
ok. I left this as a task for #179
|
FYI, some of the checks may be erroneously failing until #171 merges |
|
what still needs to be done for this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.