-
Notifications
You must be signed in to change notification settings - Fork 116
Add deduction guides for blocked_nd_range #651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
akukanov
merged 18 commits into
uxlfoundation:main
from
kboyarinov:blocked_nd_range-deduction-guides
Oct 31, 2025
Merged
Changes from 5 commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
36b19f3
Add deduction guides for blocked_nd_range
kboyarinov f996b67
Apply suggestion from @rarutyun
kboyarinov 7251c72
Apply suggestion from @rarutyun
kboyarinov de5cbbf
Specify both initilizer_list and C-array options for braced-init-list…
kboyarinov 88d966a
Merge branch 'blocked_nd_range-deduction-guides' of https://github.co…
kboyarinov c85d90b
Change synopsis of the deduction guide
kboyarinov e0802c5
Merge branch 'main' into blocked_nd_range-deduction-guides
kboyarinov bbc35c3
Minor fix
kboyarinov 10bb8ce
Merge branch 'blocked_nd_range-deduction-guides' of https://github.co…
kboyarinov eec1fec
Fix deduction guide synopsis
kboyarinov 85020ad
Minor formatting fix
kboyarinov 7b78d8d
Update source/elements/oneTBB/source/algorithms/blocked_ranges/blocke…
kboyarinov 46ee765
Update source/elements/oneTBB/source/algorithms/blocked_ranges/blocke…
kboyarinov 93c14c4
Update source/elements/oneTBB/source/algorithms/blocked_ranges/blocke…
kboyarinov 2f0622c
Update source/elements/oneTBB/source/algorithms/blocked_ranges/blocke…
kboyarinov 725d83d
Update source/elements/oneTBB/source/algorithms/blocked_ranges/blocke…
kboyarinov c37f6d5
Add note about the single brace init list
kboyarinov bda77cd
Move the note up
kboyarinov File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer keeping the previous:
template <typename Value>blocked_nd_range(/*a set of braced-init-lists of Value objects*/)-> blocked_nd_range<Value, /*number of braced-init-lists*/>;And then the detailed description provides the two options for how to do that. What's currently here seems even less clear.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You might add the "see-below" comment in addition, like
blocked_nd_range(/*a set of braced-init-lists of Value objects (see-below)*/)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Applied the combined approach with the comment below.