Merge pull request #111 from frasercrmck/memcpy-memset-always-i8

[vecz] Remove checks for non-i8 memcpy/memsets
uxlfoundation · Aug 29, 2023 · 678ee7d · 678ee7d
2 parents 83c5022 + 9dc1baa
commit 678ee7d
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 100 deletions.
diff --git a/modules/compiler/vecz/source/transform/builtin_inlining_pass.cpp b/modules/compiler/vecz/source/transform/builtin_inlining_pass.cpp
@@ -109,16 +109,6 @@ static Value *emitBuiltinMemSet(Function *F, IRBuilder<> &B,
   Value *DstPtr = Args[0];
   Type *Int8Ty = B.getInt8Ty();
 
-#if LLVM_VERSION_LESS(17, 0)
-  auto *DstPtrTy = cast<PointerType>(DstPtr->getType());
-  // FIXME: We implicitly assume pointers to i8 by doing byte-wise stores,
-  // below. See CA-4331.
-  if (!DstPtrTy->isOpaque() &&
-      multi_llvm::getPtrElementType(DstPtrTy) != Int8Ty) {
-    return nullptr;
-  }
-#endif
-
   Value *StoredValue = Args[1];
   bool IsVolatile = (Args.back() == ConstantInt::getTrue(Context));
   llvm::StoreInst *MS = nullptr;
@@ -214,19 +204,6 @@ static Value *emitBuiltinMemCpy(Function *F, IRBuilder<> &B,
   Value *SrcPtr = Args[1];
   Type *Int8Ty = B.getInt8Ty();
 
-#if LLVM_VERSION_LESS(17, 0)
-  auto *DstPtrTy = cast<PointerType>(DstPtr->getType());
-  auto *SrcPtrTy = cast<PointerType>(DstPtr->getType());
-  // FIXME: We implicitly assume pointers to i8 by doing byte-wise loads and
-  // stores, below. See CA-4331.
-  if ((!DstPtrTy->isOpaque() &&
-       multi_llvm::getPtrElementType(DstPtrTy) != Int8Ty) ||
-      ((!SrcPtrTy->isOpaque() &&
-        multi_llvm::getPtrElementType(SrcPtrTy) != Int8Ty))) {
-    return nullptr;
-  }
-#endif
-
   bool IsVolatile = (Args.back() == ConstantInt::getTrue(Context));
   llvm::StoreInst *MC = nullptr;
 

diff --git a/modules/compiler/vecz/test/lit/llvm/builtin_inlining_mem.ll b/modules/compiler/vecz/test/lit/llvm/builtin_inlining_mem.ll