Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix powr and re-enable test. #281

Merged
merged 1 commit into from
Jan 8, 2024
Merged

Fix powr and re-enable test. #281

merged 1 commit into from
Jan 8, 2024

Conversation

hvdijk
Copy link
Collaborator

@hvdijk hvdijk commented Jan 5, 2024

Overview

Fix powr and re-enable test.

Reason for change

We already treat 1 as a special case in pow(). If we treat it as a special case in powr() too, that looks to be sufficient to avoid errors caused by internal overflow.

Description of change

Describe the intended behaviour your changes are meant to introduce to the
project and explain how they resolve the problem stated above. Detail any
relevant changes that may affect other users of the project, such as
compilation options, runtime flags, expected inputs and outputs, API entry
points, etc.

If you have added new testing, provide details on what tests you have added
and what the purpose of them is.

Anything else we should know?

If there's any other relevant information we should know that may help us in
understanding and verifying your patch, please include it here.

Checklist

  • Read and follow the project Code of Conduct.
  • Make sure the project builds successfully with your changes.
  • Run relevant testing locally to avoid regressions.
  • Run clang-format-16 (the most
    recent version available through pip) on all modified code.

We already treat 1 as a special case in pow(). If we treat it as a
special case in powr() too, that looks to be sufficient to avoid
errors caused by internal overflow.
@hvdijk hvdijk merged commit ece3cd0 into uxlfoundation:main Jan 8, 2024
3 checks passed
@hvdijk hvdijk deleted the fix-powr branch January 8, 2024 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants