[NFC] Build Abacus in C++17 mode. #283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous -std=c++11 for Abacus dated from back when the default mode was C++03, it was to enable new features in Abacus. The project-wide mode now is C++17, and keeping -std=c++11 for Abacus now has the opposite effect where features we can use throughout the project are not available for Abacus. This change makes it so that the whole project uses C++17. This is a fairly large change because C++17 makes noexcept (including __attribute__((nothrow))) part of the type system, requiring us to be consistent between declaration and definition, we can no longer rely on it being picked up from a previous declaration.
frasercrmck
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
[NFC] Build Abacus in C++17 mode.
Reason for change
The previous -std=c++11 for Abacus dated from back when the default mode was C++03, it was to enable new features in Abacus. The project-wide mode now is C++17, and keeping -std=c++11 for Abacus now has the opposite effect where features we can use throughout the project are not available for Abacus. This change makes it so that the whole project uses C++17.
Description of change
This is a fairly large change because C++17 makes noexcept (including attribute((nothrow))) part of the type system, requiring us to be consistent between declaration and definition, we can no longer rely on it being picked up from a previous declaration.
Anything else we should know?
If there's any other relevant information we should know that may help us in
understanding and verifying your patch, please include it here.
Checklist
recent version available through
pip) on all modified code.