Remove CA_CL_FORCE_PROFILE #287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This had been available as a backdoor for testing embedded but this is untested and not documented and embedded is much lower priority now. If needed we should make a target which is effectively embedded, which is a much better way of testing it. This also removes an unncessary compiler dependence on the cargo module which would no longer compile if the CA_CL_FORCE_PROFILE_STRING was set as a compile option.
hvdijk
approved these changes
Jan 9, 2024
RossBrunton
approved these changes
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Remove CA_CL_FORCE_PROFILE_OPTION
Reason for change
This had been available as a backdoor for testing embedded but this is untested and not documented and embedded is much lower priority now. If needed we should make a target which is effectively embedded, which is a much better way of testing it.
Description of change
Remove all references of CA_CL_FORCE_PROFILE_OPTION or CA_CL_FORCE_PROFILE_OPTION_STRING