[PLA-150][internal] Switch Github Action to use AWS role #584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PLA-150 Use github OIDC for AWS authentication for git hub actions
Use github OIDC for AWS authentication for git hub actions so we don’t need to worry about access key/secret key. |
|
Beautiful YAML. LGTM |
owencjones
approved these changes
May 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Update GitHub Action to use AWS OIDC role instead of AWS credentials.
Details
Internal improvements around how AWS credentials are being used. At the same, this PR also upgrades
aws-actions/configure-aws-credentialsaction tov2which unfortunately will present a warning about upgrading to JavaScript v3 (see this issue for more details).