Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use set_max_old_generation_size_in_bytes, add anlex-n avatars #726

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

anlexN
Copy link

@anlexN anlexN commented Jan 10, 2024

No description provided.

@camillobruni
Copy link
Contributor

Thanks for the contribution, I don't think we usually add authors to blog-posts for minor fixes.
Would you be ok landing without the avatar changes?

@anlexN
Copy link
Author

anlexN commented Apr 17, 2024

@camillobruni excuse me, what is landing?

@@ -1,10 +1,11 @@
---
title: 'One small step for Chrome, one giant heap for V8'
author: 'guardians of the heap Ulan Degenbaev, Hannes Payer, Michael Lippautz, and DevTools warrior Alexey Kozyatinskiy'
author: 'guardians of the heap Ulan Degenbaev, Hannes Payer, Michael Lippautz, anlex N and DevTools warrior Alexey Kozyatinskiy'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes don' qualify to add yourself as an author to the post. Please remove your name and avatar from this PR.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@camillobruni teacher, I have done, please review. can it be merged now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants