-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add deprecated thing to css, post, blog #727
base: main
Are you sure you want to change the base?
Conversation
Thanks for the contribution, I don't think we'll add new authors for minor changes, would be up for landing this without that part? |
I can not! many and many docs are outdated. I think people that published the article only just publish, not update those article. I have reviewed docs step by step, I make very sure. I have still many contributions to do. After all, many docs confuse many people, including me. I also try to understand more |
I'm sorry, I can't merge this PR as is. Even with the proposed changes you don't qualify as an author for the article. |
src/blog/test-the-future.md
Outdated
@@ -1,7 +1,9 @@ | |||
--- | |||
title: 'Help us test the future of V8!' | |||
author: 'Daniel Clifford ([@expatdanno](https://twitter.com/expatdanno)), Original Munich V8 Brewer' | |||
author: 'Daniel Clifford ([@expatdanno](https://twitter.com/expatdanno)), Original Munich V8 Brewer, anlex N' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The proposed changes don't qualify for adding yourself as an author. Please remove this change here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@camillobruni teacher, I have done, please review. can it be merged now?
No description provided.