Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deprecated thing to css, post, blog #727

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

anlexN
Copy link

@anlexN anlexN commented Jan 14, 2024

No description provided.

@camillobruni
Copy link
Contributor

Thanks for the contribution, I don't think we'll add new authors for minor changes, would be up for landing this without that part?

@anlexN
Copy link
Author

anlexN commented Apr 5, 2024

I can not! many and many docs are outdated. I think people that published the article only just publish, not update those article. I have reviewed docs step by step, I make very sure. I have still many contributions to do. After all, many docs confuse many people, including me. I also try to understand more V8 source code.

@camillobruni
Copy link
Contributor

I'm sorry, I can't merge this PR as is. Even with the proposed changes you don't qualify as an author for the article.
You can land this PR and have your name in the commit log, or I will create a separate PR to fix this indepedently.

@anlexN
Copy link
Author

anlexN commented Apr 15, 2024

I have git log, my name is there.
image

You can land this PR and have your name in the commit log

what do you mean? teacher.

@camillobruni

@@ -1,7 +1,9 @@
---
title: 'Help us test the future of V8!'
author: 'Daniel Clifford ([@expatdanno](https://twitter.com/expatdanno)), Original Munich V8 Brewer'
author: 'Daniel Clifford ([@expatdanno](https://twitter.com/expatdanno)), Original Munich V8 Brewer, anlex N'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The proposed changes don't qualify for adding yourself as an author. Please remove this change here.

Copy link
Author

@anlexN anlexN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@camillobruni teacher, I have done, please review. can it be merged now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants