Fix outdated V8 Torque builtins #762
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rluvaton
commented
Apr 22, 2024
| @@ -96,16 +97,23 @@ The definition is also straightforward. The only difference to our builtin with | |||
|
|
|||
| ```torque | |||
| namespace math { | |||
| builtin HeapNumberIs42(implicit context: Context)(heapNumber: HeapNumber): | |||
| Boolean { | |||
| transitioning macro HeapNumberIs42(implicit context: Context)(heapNumber: HeapNumber): Boolean { | |||
There was a problem hiding this comment.
Lines 95-97 should be updated as well but I'm not sure what to write there
rluvaton
commented
Apr 22, 2024
| @@ -132,7 +131,7 @@ TEST(MathIsHeapNumber42) { | |||
| Heap* heap = isolate->heap(); | |||
| Zone* zone = scope.main_zone(); | |||
|
|
|||
| StubTester tester(isolate, zone, Builtins::kMathIs42); | |||
| StubTester tester(isolate, zone, Builtin::kMathIs42); | |||
There was a problem hiding this comment.
Line 126 should be updated as well, there is no more test-run-stubs.cc file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #761