Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update merge handling #763

Merged
merged 4 commits into from
May 6, 2024
Merged

Update merge handling #763

merged 4 commits into from
May 6, 2024

Conversation

lutzvahl
Copy link
Member

@lutzvahl lutzvahl commented May 3, 2024

No description provided.

@lutzvahl lutzvahl requested a review from mi-ac May 3, 2024 10:18

## How to create the merge CL

### Option 1: Using [gerrit](https://chromium-review.googlesource.com/)
### Option 1: Using [gerrit](https://chromium-review.googlesource.com/) - Recommended
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually scripted this process as https://source.chromium.org/chromium/chromium/src/+/main:v8/tools/release/merge_to_branch_gerrit.py, maybe we want to recommend that instead?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SG, does it make sense to replace Option 2 below with the new script?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sg

Copy link
Member Author

@lutzvahl lutzvahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

adjusted to use the new script

@lutzvahl lutzvahl merged commit 70e0a65 into main May 6, 2024
4 checks passed
@lutzvahl lutzvahl deleted the lutzvahl-patch-1 branch May 6, 2024 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants