Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blog entry for new JSPI API #767

Merged
merged 27 commits into from
Jun 4, 2024
Merged

Blog entry for new JSPI API #767

merged 27 commits into from
Jun 4, 2024

Conversation

fgmccabe
Copy link
Contributor

A new blog post talking about some changes to JSPI including the new API

Copy link
Contributor

@tomayac tomayac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many minor suggestions to (hopefully) improve the article.

One question that I think you should answer: how can this be feature-detected? It seems like the below could work:

// Old API:
'Suspender' in WebAssembly

// New API
'promising' in WebAssembly

src/blog/jspi-newapi.md Outdated Show resolved Hide resolved
src/blog/jspi-newapi.md Outdated Show resolved Hide resolved
src/blog/jspi-newapi.md Outdated Show resolved Hide resolved
src/blog/jspi-newapi.md Outdated Show resolved Hide resolved
src/blog/jspi-newapi.md Outdated Show resolved Hide resolved
src/blog/jspi-newapi.md Outdated Show resolved Hide resolved
src/blog/jspi-newapi.md Outdated Show resolved Hide resolved
src/blog/jspi-newapi.md Outdated Show resolved Hide resolved
src/blog/jspi-newapi.md Outdated Show resolved Hide resolved
src/blog/jspi-newapi.md Outdated Show resolved Hide resolved
fgmccabe and others added 21 commits May 31, 2024 09:41
Co-authored-by: Thomas Steiner <[email protected]>
Co-authored-by: Thomas Steiner <[email protected]>
Co-authored-by: Thomas Steiner <[email protected]>
Co-authored-by: Thomas Steiner <[email protected]>
Co-authored-by: Thomas Steiner <[email protected]>
Co-authored-by: Thomas Steiner <[email protected]>
Co-authored-by: Thomas Steiner <[email protected]>
Co-authored-by: Thomas Steiner <[email protected]>
Co-authored-by: Thomas Steiner <[email protected]>
Co-authored-by: Thomas Steiner <[email protected]>
Co-authored-by: Thomas Steiner <[email protected]>
Co-authored-by: Thomas Steiner <[email protected]>
Co-authored-by: Thomas Steiner <[email protected]>
Co-authored-by: Thomas Steiner <[email protected]>
Co-authored-by: Thomas Steiner <[email protected]>
Co-authored-by: Thomas Steiner <[email protected]>
Co-authored-by: Thomas Steiner <[email protected]>
Co-authored-by: Thomas Steiner <[email protected]>
Co-authored-by: Thomas Steiner <[email protected]>
Co-authored-by: Thomas Steiner <[email protected]>
Co-authored-by: Thomas Steiner <[email protected]>
src/blog/jspi-newapi.md Outdated Show resolved Hide resolved
@fgmccabe
Copy link
Contributor Author

@tomayac In response to the feature detection question.
It would be good to have something about feature detection. Since I am planning to update the original article, I will add it to that one.

@tomayac
Copy link
Contributor

tomayac commented May 31, 2024

@tomayac In response to the feature detection question. It would be good to have something about feature detection. Since I am planning to update the original article, I will add it to that one.

The reference blog post should have an evergreen feature detection method mentioned, and this new blog post should half a way to tell which of the two JSPI API versions the current browser supports.

@fgmccabe
Copy link
Contributor Author

I see. Yes, I will try to craft something along those lines.

Copy link
Contributor

@tomayac tomayac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one final nit suggestion for the description.

src/blog/jspi-newapi.md Outdated Show resolved Hide resolved
Co-authored-by: Thomas Steiner <[email protected]>
@fgmccabe fgmccabe merged commit 92e800f into main Jun 4, 2024
4 checks passed
@fgmccabe fgmccabe deleted the new-api branch June 4, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants