Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/add custom prefix #1

Open
wants to merge 82 commits into
base: master
Choose a base branch
from

Conversation

va-stefanek
Copy link
Owner

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

Allow to specify custom prefix for the action

[ ] Bugfix
[X] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Closes #

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

timdeschryver and others added 30 commits January 16, 2021 15:04
…ngrx#2885)

* feat(store): add object-style StoreModule.forFeature overload (ngrx#2821)

Closes ngrx#2809

* fix(store): update StoreModule to be compliant with AOT

Co-authored-by: Suguru Inatomi <[email protected]>
* feat(store): rename Props interface to ActionCreatorProps

Closes ngrx#2808

* docs(store): rename Props interface to ActionCreatorProps

* feat(store): rename On interface to ReducerTypes

Closes ngrx#2854

* docs(store): rename On interface to ReducerTypes
)

The deprecated function 'empty()' is replaced with 'EMPTY' object.

Closes ngrx#2891
…rx#2906)

TypeScript only recognizes the overloads as method signatures when being overloaded not the actual implementation, added overload for the case where isOptimistic is true or undefined (default for entity).

This will allow for the following:

`.add(entityWithoutId, { isOptimistic: false })`
`.add(entityWithId, { isOptimistic: true })`
`.add(entityWithId, { // any other options without whatever settings and no explicit value for isOptimistic })`
`.add(entityWithId)`
…rx#2907)

BREAKING CHANGE:

BEFORE:

ngrxPush typing doesn't consider `undefined` when the input type is an observable

AFTER:

ngrxPush typing considers `undefined` when the input type is an observable

Closes ngrx#2888
jordanpowell88 and others added 30 commits April 10, 2021 11:32
BREAKING CHANGE:

The minimum TypeScript version has been updated to 4.1.x

BEFORE:

The minimum TypeScript version is 4.0.x

AFTER:

The minimum TypeScript version is 4.1.x
BREAKING CHANGES:

Minimum versions of Angular and TypeScript have been updated

BEFORE:

Minimum of Angular version 11.x
Minimum of TypeScript 4.1.x

AFTER:

Minimum of Angular version 12.x
Minimum of TypeScript 4.2.x
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.