Open
Conversation
* DomEvent: use passive for touchmove (instead of touchend) Ref: https://developers.google.com/web/tools/lighthouse/audits/passive-event-listeners * Remove excessive brackets from condition * DomEvent: simplify more conditions Also add passive option for `wheel` event listeners (previously it was supported for `mousewheel` only) * Prefer `wheel` over `mousewheel` throughout sources
…n-) (#7094) GridLayer/_setView: check max/minZoom before clamping to max/minNativeZoom
* Enable to load muted video * Changes after CR Co-authored-by: r <r>
* MapSpec.js: fix: mocked function must be restored Otherwise it will break crs.project test in CRSSpec.js * MapSpec.js: skip broken test crsMock.verify() call is mandatory here, but it shows that crs.project is never called, thus the test is not ever valid. * MapSpec.js: fix non-valid test Revert 50a4845 and 1b1d96a, and refactor a bit (rather cosmetical changes) * MapSpec.js: fix more tests Refactor before/afterEach hooks for more careful setup/cleanup. Fix some non-valid tests: * #remove - "undefines container._leaflet" - "unbinds events" * #removeLayer - "when the last tile layer on a map is removed" - "when a tile layer is removed from a map and it had greater zoom level coverage than the remainding layer" - "when a tile layer is removed from a map it and it had lesser or the sa,e zoom level coverage as the remainding layer(s)" * GridLayerSpec.js: fix some tests Refactor before/afterEach hooks for more careful setup/cleanup. Fix some non-valid tests: * "when a tilelayer is added to a map that already has a tilelayer" * spec/suites/**: refactor for more careful setup/cleanup Refactor before/afterEach hooks Other minor changes * SpecHelper.js: rename skipIn(non)Phantom to skipIf(No)3d ..to make things more clear Remove unused helper functions * Update testing deps sinon.js: left on 7.5.0 (latest still working on PhantomJS) karma-rollup-preprocessor: left on 6.1.2 (latest still supporting rollup < 1.0.0) * CRSSpec.js: workaround round-off error in Chrome L.CRS.zoom(L.CRS.scale(2.5)) results 2.4999999999999996 in Chrome Note: comparing floating point numbers properly is hard, e.g. see https://randomascii.wordpress.com/2012/02/25/comparing-floating-point-numbers-2012-edition/ * Fix touch tests failing in Chrome * karma.conf.js: add custom Chrome config to make some tests pass npm run test-nolint -- --browsers Chrome1280x1024 * spec/.eslintrc: do not forbid no-unused-vars rule * spec/.eslintrc: do not forbid more rules no-extend-native no-irregular-whitespace no-shadow * Add karma-edge-launcher * Add karma-ie-launcher Some test fails atm, see log: > karma start ./spec/karma.conf.js "--browsers" "IE" ................................................................................ ..... WARN: 'Deprecated include of L.Mixin.Events: this property will be removed in future releases, please inherit from L.Evented instead.', undefined ................................................................................ ................................................................................ ............................................................... IE 11.0 (Windows 10) ImageOverlay _image when loaded should raise the load event FAILED TypeError: Argument not optional at raiseImageEvent (spec/suites/layer/ImageOverlaySpec.js:66:4) at Anonymous function (spec/suites/layer/ImageOverlaySpec.js:74:5) IE 11.0 (Windows 10) ImageOverlay _image when load fails should raise the error event FAILED TypeError: Argument not optional at raiseImageEvent (spec/suites/layer/ImageOverlaySpec.js:66:4) at Anonymous function (spec/suites/layer/ImageOverlaySpec.js:83:5) IE 11.0 (Windows 10) ImageOverlay _image when load fails should change the image to errorOverlayUrl FAILED TypeError: Argument not optional at raiseImageEvent (spec/suites/layer/ImageOverlaySpec.js:66:4) at Anonymous function (spec/suites/layer/ImageOverlaySpec.js:88:5) .. IE 11.0 (Windows 10) ImageOverlay #setZIndex should update the z-index of the image if it has allready been added to the map FAILED Error: expected 1 to equal '1' at Assertion.prototype.assert (node_modules/expect.js/index.js:102:7) at Assertion.prototype.equal (node_modules/expect.js/index.js:216:5) at Anonymous function (node_modules/expect.js/index.js:69:13) at Anonymous function (spec/suites/layer/ImageOverlaySpec.js:111:4) IE 11.0 (Windows 10) ImageOverlay #setZIndex should set the z-index of the image when it is added to the map FAILED Error: expected 10 to equal '10' at Assertion.prototype.assert (node_modules/expect.js/index.js:102:7) at Assertion.prototype.equal (node_modules/expect.js/index.js:216:5) at Anonymous function (node_modules/expect.js/index.js:69:13) at Anonymous function (spec/suites/layer/ImageOverlaySpec.js:121:4) IE 11.0 (Windows 10) ImageOverlay #setZIndex should use the z-index specified in options FAILED Error: expected 20 to equal '20' at Assertion.prototype.assert (node_modules/expect.js/index.js:102:7) at Assertion.prototype.equal (node_modules/expect.js/index.js:216:5) at Anonymous function (node_modules/expect.js/index.js:69:13) at Anonymous function (spec/suites/layer/ImageOverlaySpec.js:127:4) ........................................................................ IE 11.0 (Windows 10) Marker.Drag drag in CSS scaled container drags a marker with mouse, compensating for CSS scale FAILED expected 0 to be within -50..-30 (node_modules/expect.js/index.js:102) ................................................................................ ........................................................... WARN: 'Deprecated use of _flat, please use L.LineUtil.isFlat instead.' . WARN: 'Deprecated use of _flat, please use L.LineUtil.isFlat instead.' .......................................................................... 05 2020 15:25:48.917:WARN [web-server]: : /000 05 2020 15:25:48.938:WARN [web-server]: : /000 ...... .. IE 11.0 (Windows 10) Map #invalidateSize pans by the right amount when growing in 1px increments FAILED Error: expected 0 to equal 1 at Assertion.prototype.assert (node_modules/expect.js/index.js:102:7) at Assertion.prototype.equal (node_modules/expect.js/index.js:216:5) at Anonymous function (node_modules/expect.js/index.js:69:13) at Anonymous function (spec/suites/map/MapSpec.js:649:4) IE 11.0 (Windows 10) Map #invalidateSize pans by the right amount when shrinking in 1px increments FAILED Error: expected 0 to equal -1 at Assertion.prototype.assert (node_modules/expect.js/index.js:102:7) at Assertion.prototype.equal (node_modules/expect.js/index.js:216:5) at Anonymous function (node_modules/expect.js/index.js:69:13) at Anonymous function (spec/suites/map/MapSpec.js:667:4) .. IE 11.0 (Windows 10) Map #invalidateSize emits a move event if the size has changed FAILED Error: expected false to be truthy at Assertion.prototype.assert (node_modules/expect.js/index.js:102:7) at Assertion.prototype.ok (node_modules/expect.js/index.js:115:5) at Anonymous function (node_modules/expect.js/index.js:499:7) at Anonymous function (spec/suites/map/MapSpec.js:700:4) IE 11.0 (Windows 10) Map #invalidateSize emits a moveend event if the size has changed FAILED Error: expected false to be truthy at Assertion.prototype.assert (node_modules/expect.js/index.js:102:7) at Assertion.prototype.ok (node_modules/expect.js/index.js:115:5) at Anonymous function (node_modules/expect.js/index.js:499:7) at Anonymous function (spec/suites/map/MapSpec.js:710:4) IE 11.0 (Windows 10) Map #invalidateSize debounces the moveend event if the debounceMoveend option is given FAILED Error: expected false to be truthy at Assertion.prototype.assert (node_modules/expect.js/index.js:102:7) at Assertion.prototype.ok (node_modules/expect.js/index.js:115:5) at Anonymous function (node_modules/expect.js/index.js:499:7) at Anonymous function (spec/suites/map/MapSpec.js:724:4) IE 11.0 (Windows 10) Map #invalidateSize correctly adjusts for new container size when view is set during map initialization (#6165) FAILED Error: expected 0 to equal 100 at Assertion.prototype.assert (node_modules/expect.js/index.js:102:7) at Assertion.prototype.equal (node_modules/expect.js/index.js:216:5) at Anonymous function (spec/suites/map/MapSpec.js:745:4) ................ IE 11.0 (Windows 10) Map #fitBounds after layers set Snaps to a number after adding tile layer FAILED Error: Access is denied. at createTile (src/Leaflet.js:11698:3) at _addTile (src/Leaflet.js:11433:3) at _update (src/Leaflet.js:11330:5) at _setView (src/Leaflet.js:11191:5) at _resetView (src/Leaflet.js:11146:3) at onAdd (src/Leaflet.js:10784:3) at _layerAdd (src/Leaflet.js:6580:3) at Events.fire (src/Leaflet.js:588:6) at _resetView (src/Leaflet.js:4184:4) at setView (src/Leaflet.js:3181:3) .............................. IE 11.0 (Windows 10) Map.Drag mouse events in CSS scaled container change the center of the map, compensating for CSS scale FAILED expected 31.952162238024975 to be within 21.943..21.9431 (node_modules/expect.js/index.js:102) IE 11.0 (Windows 10) Map.Drag touch events change the center of the map FAILED Object doesn't support this action (node_modules/prosthetic-hand/dist/prosthetic-hand.js:624) IE 11.0 (Windows 10) Map.Drag touch events does not change the center of the map when finger is moved less than the drag threshold FAILED Object doesn't support this action (node_modules/prosthetic-hand/dist/prosthetic-hand.js:624) IE 11.0 (Windows 10) Map.Drag touch events reset itself after touchend FAILED Object doesn't support this action (node_modules/prosthetic-hand/dist/prosthetic-hand.js:624) ............. IE 11.0 (Windows 10) Map.TouchZoom Increases zoom when pinching out FAILED Object doesn't support this action (node_modules/prosthetic-hand/dist/prosthetic-hand.js:624) IE 11.0 (Windows 10) Map.TouchZoom Decreases zoom when pinching in FAILED Object doesn't support this action (node_modules/prosthetic-hand/dist/prosthetic-hand.js:624) IE 11.0 (Windows 10): Executed 685 of 688 (20 FAILED) (skipped 3) (25.993 secs / 22.211 secs) * karma.conf.js: additional Firefox configs - FirefoxPointer - FirefoxTouch - FirefoxPointerTouch * .travis.yml: run CI tests with different Firefox configs Use FirefoxHeadless * karma.conf.js: change reporter to default ('progress') Because 'dots' is confusing when mixed up with different warnings. But for CI script 'dots' fits better due to travis-ci log qualities. * .travis.yml: run CI tests with Chrome too
Because of particular quality of `for ... in` loop, type of `z` is 'string'. Thus condition `z === zoom` never met in _updateLevels. Considering wrong arg type, _removeTilesAtZoom also never had any action. Cleaner solution would be to iterate `Object.keys()` instead, but it is available only since IE 9.
* Update rollup-plugin-git-version to ^0.3.1 * Update uglify-js to ^3.9.2 * Update git-rev-sync to ^2.0.0 * Update ssri to ^8.0.0 * Update rollup to ^0.59.4 (latests version with support of IE 8) Remove Object.freeze hack, use rollup's `output.freeze` option instead * Update eslint to ^5.16.0 And fix a couple of warnings. Ref: https://eslint.org/docs/user-guide/migrating-to-5.0.0#eslint-recommended-changes https://eslint.org/docs/user-guide/migrating-to-5.0.0#deprecated-globals * Update eslint to ^6.8.0 Ref: https://eslint.org/docs/user-guide/migrating-to-6.0.0#eslint-recommended-changes
This commit fixes issue #6764, see the discussion examples there. It's an alternative implementation for pull request #6116. It makes `tooltipAnchor` behave the same like `popupAnchor` regardless of the tooltip's direction. With one exception: the `auto` direction flips the `x` axis of `tooltipAnchor` and the tooltip's `offset` when it switches to `left` depending on the position on the screen. `auto` therefore assumes that the icon is somewhat symmetrical to the left and the right of the y axis, which is the case for the default icon.
That code was initially intended to support mspointer-touch, but currently same code paths are used in any PointerEvent-enabled browser, and may cause real issues (e.g. that broke Leaflet.draw). Note: It's known that preventDefault is needed for correct processing of touch in IE10. But I haven't found any evidence that it is required for IE11, so I've removed some excessive code. It's blind shot as I have no IE10-11 devices to test, but it will be easy to fix on request.
Removed emoji for consistency. I'm not aware we wanted to highlight any plugin over the rest with little stars.
* Add Leaflet.BigImage * plugins: Tweak text for Leaflet.BigImage Co-authored-by: Iván Sánchez Ortega <ivan@sanchezortega.es>
Co-authored-by: m.sajid <m.sajid@transfermedia.de>
This [plugin](https://github.com/coyotesqrl/Leaflet.ArrowCircle) allows for the creation of circle markers with directional arrows.
* Changelog and blog post for 1.7.0 * Tweak test for finger drag Apparently, some of the changes related to pointer events have made that touch-dragging less than the threshold now force a recalculation of the map center - the value is the same, so is == equal to the previous center but not === the same LatLng instance. * Bump to v1.7.1; fix uglifyjs script; update integrity hashes * Website stuff updated for 1.7.1 * Update CHANGELOG.md Co-authored-by: Vladimir Agafonkin <agafonkin@gmail.com> * Update docs/_posts/2020-09-03-leaflet-1.7.1.md Co-authored-by: Vladimir Agafonkin <agafonkin@gmail.com> * docs: 1.7.1 release announcement tweaks; delay dates by one day Co-authored-by: Vladimir Agafonkin <agafonkin@gmail.com>
Co-authored-by: 金建强 <jinjq@qh-iot.com>
…gation by not stripping outline on focus for keyboard events. (#7259) Co-authored-by: Jason Finch <jason.finch@hpw.qld.gov.au>
Tap handler is useful only in iOS
Atm it is still needed to simulate taphold in iOS
Remove exaggeration
#7279) when `document.namespaces.add()` throws `TypeError: Cannot read property 'add' of undefined`. * I am not sure why Google Chrome does not garbage collect this TypeError because clearly it is not used in the returned fn. But if you look at memory Heap snapshot, you can see it persists after garbage collection. * Try it with any leaflet map such as https://leafletjs.com/ and search heap snapshot for 'TypeError' * With this change, the `TypeError` is garbage collected and not in memory heap snapshot.
There is a small typo in spec/suites/map/MapSpec.js. Should read `simplicity` rather than `somplicity`.
* Fix opening / closing tooltip while dragging map * Fix lint * Update src/layer/Tooltip.js Co-authored-by: johnd0e <johnd0e@mail.ua> Co-authored-by: johnd0e <johnd0e@mail.ua>
* Update the doc of DivOverlay * Moved popup options from DivOverlay to Popup
Bumps [eslint](https://github.com/eslint/eslint) from 8.4.1 to 8.5.0. - [Release notes](https://github.com/eslint/eslint/releases) - [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md) - [Commits](eslint/eslint@v8.4.1...v8.5.0) --- updated-dependencies: - dependency-name: eslint dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Prevent browser (mostly Firefox) resource depletion by premature optimization usage of `will-change`. At the municipality of Amsterdam, we're heavily relying on Leaflet and having map instances open regularly leads to degraded performance in Firefox, because of the use of `will-change`.
A reset view control for Leaflet. Design for [Drupal Leaflet Module](https://www.drupal.org/project/leaflet) integration. Signed-off-by: Wong Hoi Sing Edison <hswong3i@pantarei-design.com>
A sync view control for Leaflet. Design for [Drupal Leaflet Module](https://www.drupal.org/project/leaflet) integration. Signed-off-by: Wong Hoi Sing Edison <hswong3i@pantarei-design.com>
Bumps [rollup](https://github.com/rollup/rollup) from 2.61.1 to 2.62.0. - [Release notes](https://github.com/rollup/rollup/releases) - [Changelog](https://github.com/rollup/rollup/blob/master/CHANGELOG.md) - [Commits](rollup/rollup@v2.61.1...v2.62.0) --- updated-dependencies: - dependency-name: rollup dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [eslint](https://github.com/eslint/eslint) from 8.5.0 to 8.6.0. - [Release notes](https://github.com/eslint/eslint/releases) - [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md) - [Commits](eslint/eslint@v8.5.0...v8.6.0) --- updated-dependencies: - dependency-name: eslint dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
* Update marker: default role=button, default alt=marker * fix marker test Co-authored-by: Vladimir Agafonkin <agafonkin@gmail.com>
Bumps [rollup](https://github.com/rollup/rollup) from 2.62.0 to 2.63.0. - [Release notes](https://github.com/rollup/rollup/releases) - [Changelog](https://github.com/rollup/rollup/blob/master/CHANGELOG.md) - [Commits](rollup/rollup@v2.62.0...v2.63.0) --- updated-dependencies: - dependency-name: rollup dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [karma](https://github.com/karma-runner/karma) from 6.3.9 to 6.3.10. - [Release notes](https://github.com/karma-runner/karma/releases) - [Changelog](https://github.com/karma-runner/karma/blob/master/CHANGELOG.md) - [Commits](karma-runner/karma@v6.3.9...v6.3.10) --- updated-dependencies: - dependency-name: karma dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Improve site accesibility * Prettier formatting reverted * Removed typo in docs/docs/css/main.css
Bumps [karma](https://github.com/karma-runner/karma) from 6.3.10 to 6.3.11. - [Release notes](https://github.com/karma-runner/karma/releases) - [Changelog](https://github.com/karma-runner/karma/blob/master/CHANGELOG.md) - [Commits](karma-runner/karma@v6.3.10...v6.3.11) --- updated-dependencies: - dependency-name: karma dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [mocha](https://github.com/mochajs/mocha) from 9.1.3 to 9.1.4. - [Release notes](https://github.com/mochajs/mocha/releases) - [Changelog](https://github.com/mochajs/mocha/blob/master/CHANGELOG.md) - [Commits](mochajs/mocha@v9.1.3...v9.1.4) --- updated-dependencies: - dependency-name: mocha dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [rollup](https://github.com/rollup/rollup) from 2.63.0 to 2.64.0. - [Release notes](https://github.com/rollup/rollup/releases) - [Changelog](https://github.com/rollup/rollup/blob/master/CHANGELOG.md) - [Commits](rollup/rollup@v2.63.0...v2.64.0) --- updated-dependencies: - dependency-name: rollup dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [eslint](https://github.com/eslint/eslint) from 8.6.0 to 8.7.0. - [Release notes](https://github.com/eslint/eslint/releases) - [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md) - [Commits](eslint/eslint@v8.6.0...v8.7.0) --- updated-dependencies: - dependency-name: eslint dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
…ontent-wrapper` (#7920)
* fixing noConflict and merge rollup-config * Fix lint
* Refactor openPopup/Tooltip to use common functions [Map/Layer]\_initOverlay * DivOverlay: common functions openOn/close Refactor [Map\Layer] open/close-Popup/Tooltip to use DivOverlay's openOn/close * DivOverlay: new public method `toggle` Refactor Layer\ togglePopup/Tooltip: use common method DivOverlay\toggle Popup: do not clear map._popup on close as it's redundant
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
19 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.