Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Java API to set Chart mode property #6994

Closed
wants to merge 5 commits into from

Conversation

bwajtr
Copy link
Contributor

@bwajtr bwajtr commented Jan 2, 2025

Description

The PR vaadin/web-components#8424 introduced a new mode property on <vaadin-chart> component.

This PR adds a Java API to set this mode property. Also deprecates the setTimeline() in favor of setMode() - a change similar to deprecation in the web-component.

Part of #4731

Type of change

  • Bugfix
  • Feature

Checklist

  • I have read the contribution guide: https://vaadin.com/docs/latest/contributing/overview
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.
  • [] I have not completed some of the steps above and my pull request can be closed immediately.

Additional for Feature type of change

  • Enhancement / new feature was discussed in a corresponding GitHub issue and Acceptance Criteria were created.

Copy link

sonarqubecloud bot commented Jan 8, 2025

@bwajtr
Copy link
Contributor Author

bwajtr commented Jan 8, 2025

After a discussion between me, Rolf and Diego we decided to not go in the direction of the mode property, but instead we will make the API more simple by just activating the Gantt chart if the chart type is Gantt.

This makes this PR quite obsolete, because then it boils down to a very few changes on the Java side (basically only by adding the ChartType.GANTT)
Closing this PR and will make the necessary changes directly in this PR:
#6997

@bwajtr bwajtr closed this Jan 8, 2025
@bwajtr bwajtr deleted the feat/4731-add-chart-mode-api branch January 8, 2025 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant