Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: deprecate usage of Date in favor of Instant #6995

Merged
merged 3 commits into from
Jan 8, 2025

Conversation

bwajtr
Copy link
Contributor

@bwajtr bwajtr commented Jan 3, 2025

Description

In relation to the Gantt chart support implementation, this change adds convenient methods setMin(Instant) and setMax(Instant) to the Axis class.

At the same time, the Date variants of these methods are marked as deprecated because the underlying Util.toHighchartsTS(Date) method that is being used by setMin and setMax is deprecated as well (from before).

Part of #4731

Type of change

  • Bugfix
  • Feature

Checklist

  • I have read the contribution guide: https://vaadin.com/docs/latest/contributing/overview
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.
  • I have not completed some of the steps above and my pull request can be closed immediately.

Additional for Feature type of change

  • Enhancement / new feature was discussed in a corresponding GitHub issue and Acceptance Criteria were created.

@bwajtr bwajtr enabled auto-merge (squash) January 8, 2025 16:40
Copy link

sonarqubecloud bot commented Jan 8, 2025

@bwajtr bwajtr merged commit 363db24 into main Jan 8, 2025
5 checks passed
@bwajtr bwajtr deleted the feat/4731-deprecate-date-methods branch January 8, 2025 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants