fix: allow to set any type of PlotOptions to Navigator.series #6996
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
Navigator
class allows setting additional plot options in thenavigator.series
attribute → the navigator uses it to configure the small charts that is visible under the main chart.According to the API spec, you should be able to set any PlotOptions type to the
navigator.series
attribute (any subclass ofAbstractPlotOptions
).However, in the Vaadin Chart Java API, the
navigator.series
attribute was defined asPlotOptionsSeries
- which itself is a subclass ofAbstractPlotOptions
. During the implementation of Gantt chart support in I faced the issue, that this is not enough, and you can't configure the Navigator as you want this way. For example, you can't use thePlotOptionsGantt
asnavigator.series
becausePlotOptionsGantt
is not a subclass ofPlotOptionsSeries
— in fact, none of thePlotOptions***
classes is.So you cannot do for example the following:
This change changes the type of the
navigator.series
attribute toAbstractPlotOptions
, so you can set there any plot options and therefore configure the navigator properly.This change is backwards compatible.
Part of #4731
Type of change
Checklist