-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Spring Data API for Grid #7011
base: main
Are you sure you want to change the base?
Conversation
TC Format Checker Report - 11:48 - 08 - JanThere are 1 files with format errors
Here is the list of files with format issues in your PR:
|
Very good, almost like I would have done it 😁 "Spring" alone in the naming doesn't sound quite right though. I'd at least expand that to SpringData as that is where the Pageable is located in. Couple of other drafts I tried yesterday in my IDE, but I feel like the best option is missing from the list:
I'd pick this last one if other lazy methods wouldn't already drive people toward setItems, maybe still a good option 🤷♂️ |
|
It intentionally starts with |
Provides a Spring Data specific setItems variant based on Pageable. The method is called setItemsSpring because the signature is the same as existing setItems methods. Used as e.g. ``` grid.setItemsSpring(pageable -> productService.list(pageable)) ```
fa8af01
to
e369386
Compare
Quality Gate passedIssues Measures |
Provides a Spring Data specific setItems variant based on Pageable.
The method is called setItemsSpring because the signature is the same as existing setItems methods.
Used as e.g.