Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use upgraded Atmosphere version for Push #10582

Closed
wants to merge 7 commits into from

Conversation

denis-anisimov
Copy link
Contributor

fixes #10103

@caalador
Copy link
Contributor

caalador commented Apr 8, 2021

Reconnect websocket tests fail seemingly not getting the connection before timeout.

@caalador
Copy link
Contributor

caalador commented Apr 9, 2021

The rebase/merge from master failed somehow as now I see files and changes for everything and the PR is suddenly +1,423 −530

@pleku pleku linked an issue Apr 9, 2021 that may be closed by this pull request
@caalador caalador force-pushed the 10103-push-page-reload-master branch from b594033 to c423534 Compare April 12, 2021 05:22
@vaadin-bot
Copy link
Collaborator

SonarQube analysis reported 31 issues

  • INFO 31 info

Top 10 extra issues

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

  1. INFO Constants.java#L43: Do not forget to remove this deprecated code someday. rule
  2. INFO Constants.java#L62: Do not forget to remove this deprecated code someday. rule
  3. INFO Constants.java#L69: Do not forget to remove this deprecated code someday. rule
  4. INFO Constants.java#L77: Do not forget to remove this deprecated code someday. rule
  5. INFO Constants.java#L84: Do not forget to remove this deprecated code someday. rule
  6. INFO Constants.java#L91: Do not forget to remove this deprecated code someday. rule
  7. INFO Constants.java#L99: Do not forget to remove this deprecated code someday. rule
  8. INFO Constants.java#L107: Do not forget to remove this deprecated code someday. rule
  9. INFO Constants.java#L115: Do not forget to remove this deprecated code someday. rule
  10. INFO Constants.java#L123: Do not forget to remove this deprecated code someday. rule

@denis-anisimov
Copy link
Contributor Author

2.7.0 either has a regression or requires changes in vaadin atmosphere client engine code.

@vaadin-bot
Copy link
Collaborator

Hi @denis-anisimov , this commit cannot be picked to 6.0 by this bot, can you take a look and pick it manually?
Error Message: Error: Command failed: git cherry-pick 1581635
fatal: bad object 1581635

@ZheSun88
Copy link
Contributor

looks like this PR has been closed without merging.. so no cherry picks

@caalador caalador deleted the 10103-push-page-reload-master branch February 15, 2022 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants