Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(form): support validation change events #2902

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

platosha
Copy link
Contributor

Fixes #2702

@platosha platosha added the hilla Issues related to Hilla label Nov 12, 2024
@platosha platosha force-pushed the fix/validated-event branch 3 times, most recently from 5d646e1 to 433cce2 Compare December 3, 2024 16:24
Copy link

codecov bot commented Dec 3, 2024

Codecov Report

Attention: Patch coverage is 75.67568% with 9 lines in your changes missing coverage. Please review.

Project coverage is 92.33%. Comparing base (3d07524) to head (affe730).

Files with missing lines Patch % Lines
packages/ts/lit-form/src/Field.ts 71.87% 7 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2902      +/-   ##
==========================================
- Coverage   92.56%   92.33%   -0.23%     
==========================================
  Files          84       84              
  Lines        3160     3183      +23     
  Branches      772      775       +3     
==========================================
+ Hits         2925     2939      +14     
- Misses        183      190       +7     
- Partials       52       54       +2     
Flag Coverage Δ
unittests 92.33% <75.67%> (-0.23%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@platosha platosha marked this pull request as ready for review December 4, 2024 14:19
@platosha platosha requested a review from Lodin December 4, 2024 14:42
@platosha platosha changed the base branch from 24.5 to main December 4, 2024 14:43
@platosha platosha force-pushed the fix/validated-event branch from 66c2e26 to 485b08c Compare December 4, 2024 14:45
@Lodin
Copy link
Contributor

Lodin commented Dec 12, 2024

I see several issues in SonarCloud and incomplete coverage from Codecov. Would it be possible to fix them?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hilla Issues related to Hilla
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Binder does not always invalidate bad input
2 participants