fix: Fix HazelcastConnector failure with Hazelcast client #271
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Skip shutdown hook warning check when using a Hazelcast client, as ClientDynamicClusterConfig does not support reading properties and shutdown hook is not relevant for HazelcastClient. Fixes #268
heruan
approved these changes
Jan 12, 2026
mcollovati
deleted the
issues/268-prevent_failures_reading_hazelcast_config
branch
vaadin-bot
pushed a commit
that referenced
this pull request
Jan 12, 2026
Skip shutdown hook warning check when using a Hazelcast client, as ClientDynamicClusterConfig does not support reading properties and shutdown hook is not relevant for HazelcastClient. Fixes #268
mcollovati
added a commit
that referenced
this pull request
Jan 12, 2026
Skip shutdown hook warning check when using a Hazelcast client, as ClientDynamicClusterConfig does not support reading properties and shutdown hook is not relevant for HazelcastClient. Fixes #268 Co-authored-by: Marco Collovati <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skip shutdown hook warning check when using a Hazelcast client, as ClientDynamicClusterConfig does not support reading properties and shutdown hook is not relevant for HazelcastClient.
Fixes #268
Description
Please list all relevant dependencies in this section and provide summary of the change, motivation and context.
Fixes # (issue)
Type of change
Checklist
Additional for
Featuretype of change