New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor RedirectService::addRedirect() #10

Open

mmikkel wants to merge 1 commit into master from feature/refactor-add-redirect

Member

mmikkel commented Mar 3, 2024 •

edited

Loading

Refactors how existing redirects are handled when adding new redirects (or editing existing ones):

Existing redirects are never updated, only deleted, if the redirect being added (or edited) has the same siteId (or a null siteId) as the existing one
If an existing redirect has the same sourceUrl, but a different siteId from the redirect being saved, it's left alone
In querying for existing or conflicting redirects when saving an edited redirect, the id param is added to the queries

This solves some unexpected behaviours when adding new redirects or editing existing ones.


          Refactor RedirectService::addRedirect()

1d68fca

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet