Feature/203 vite #298
Merged
Feature/203 vite #298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # .eslintrc.js # package.json # src/setup/i18n.ts # src/stores/plugins/api.ts # src/types/index.d.ts # src/types/initial-data.d.ts # src/types/initial-data.ts
…aged config to separate file for better TSC support
# Conflicts: # package-lock.json # src/assets/icons.svg # src/types/image.d.ts
# Conflicts: # package-lock.json # package.json # src/stores/session.ts # src/styleguide/components/s-demo-settings.vue # webpack.config.js # .eslint.js
patric-eberle
added
enhancement
# Conflicts: # src/components/e-table.vue # src/styleguide/routes/r-google-maps.vue # webpack.config.js # src/stores/session.ts
# Conflicts: # src/components/e-progress.vue # src/directives/outside-click.ts # src/stores/session.ts # webpack.config.js
|
@MB-web can you please check my changes? I was also able to remove additional packages 🎉 |
MB-web
approved these changes
Feb 15, 2023
|
@patric-eberle Changes are fine, can be merged from my side. I have updated |
@MB-web thank you for the update. Unfortunately we will also have to write a new plugin for vite... else no message will be shown anymore. |
…ne icons while keeping 'img' and CSS size support
Applies modal improvements from reference project.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request
This PR replaces the webpack builder with Vite. Additionally it improves the TypeScript integration to get better feedback about invalid types. It also extends the test scripts with the TypeScript test. Several packages could be removed because of this change. I also switched the Storybook builder to Vite for better compatibility.
Ticket
#203
Browser testing
Checklist
Review/Test checklist