Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#311 Tooltip enhancements #339

Merged
merged 5 commits into from
Jan 16, 2024
Merged

#311 Tooltip enhancements #339

merged 5 commits into from
Jan 16, 2024

Conversation

patric-eberle
Copy link
Member

Pull request

This PR improves the tooltip implementation according to the findings from the last project. It will mainly prevent duplicated items in the code. I also decided to change a related TS interface to type, which had some side effects.

Note: there is still a bug when using multiple tooltips beside each other. Since this issue already exists in the source project, and I was a bit overwhelmed by the issue, I made a bug ticket for now: #337

Ticket

#311

Browser testing

Checklist

  • I merged the current development branch (before testing)
  • Added JSDoc and styleguide demo
  • Tested all links in project relevant browsers
  • Tested all links in different screen sizes
  • Did run automated tests and linters
  • Did assign ticket
  • Double checked target branch

Review/Test checklist

  • Did review code and documentation
  • Tested all links in project relevant browsers
  • Tested all links in different screen sizes
  • Did check accessibility (Wave, only errors)
  • Re-assign ticket to developer

@patric-eberle patric-eberle added enhancement New feature or request vue-3 Will only be done for the vue-3 version labels Jan 3, 2024
@patric-eberle patric-eberle requested a review from mob8607 January 3, 2024 13:17
@patric-eberle patric-eberle requested review from BeneRichi and removed request for mob8607 January 11, 2024 10:28
@patric-eberle patric-eberle assigned BeneRichi and unassigned mob8607 Jan 11, 2024
@patric-eberle
Copy link
Member Author

@BeneRichi can you please also review my changes on this branch? THX.

BeneRichi
BeneRichi requested changes Jan 12, 2024
View reviewed changes
Copy link

@BeneRichi BeneRichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Browser review looks fine 👍

@BeneRichi BeneRichi assigned patric-eberle and unassigned BeneRichi Jan 12, 2024
@patric-eberle
Copy link
Member Author

@BeneRichi applied the requested changes. Please also check my responses to some of the comments and check code again.

Base automatically changed from feature/331_improve-ts-config to develop January 16, 2024 10:18
BeneRichi
BeneRichi approved these changes Jan 16, 2024
View reviewed changes
Copy link

@BeneRichi BeneRichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested again. Works still fine. Amazing!

@patric-eberle
Merge remote-tracking branch 'origin/develop' into feature/311_tooltip
9a5c2e9 
# Conflicts:
#	src/plugins/tooltip/c-tooltip.vue
#	src/plugins/tooltip/directives/directive.ts
#	src/types/custom-directive.d.ts
@patric-eberle patric-eberle merged commit d576cfe into develop Jan 16, 2024
@patric-eberle patric-eberle deleted the feature/311_tooltip branch January 16, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BeneRichi BeneRichi BeneRichi approved these changes

Assignees

@BeneRichi BeneRichi

@patric-eberle patric-eberle

Labels
enhancement New feature or request vue-3 Will only be done for the vue-3 version
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@patric-eberle @BeneRichi @mob8607