Feature/321 Migrates e-date and c-date-picker component #344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into r-forms. - Adds pikaday dependency and type definition.
BeneRichi
added
enhancement
patric-eberle
requested changes
Jan 9, 2024
There was a problem hiding this comment.
Browser review
- The calendar icon can not be used to interact with the field. Nothing happens if you click on the icon.
- I would recommend to remove the calendar icon from the "date only" (without calendar popover) field.
- When the calendar is shown, the field content also gets the black background. I would recommend to kepp the background white.
- It is not possible to change to a different month.
- Even though the calendar value changes, the displayed field value never does.
- There is no spacing between the calendar title and the close icon (on mobile):
Optional
- It seems not to be possible to enter single digit dates (without a leading
0). e.g. 1.1.2024. - When opening and closing the calendar again and then running a WAVE test, the column headers are missing in the table. I don't think this would be an easy fix... But Probably also not a real problem, since the calendar will not be shown to the visitor in this case anyway.
- Re-Orders z-index variables - Changes root div element to span in e-date - Adds nextThick in mounted hook in c-date-picker
# Conflicts: # src/compositions/form-states.ts
|
@BeneRichi the browser review issues are still open. |
I know. I would have let you know as soon as I had made all the changes. |
added 2 commits
January 12, 2024 14:49
- Adds slot within e-date. - Adds pointer-events: none to e-input for the e-icon.
…thub.com/valantic/vue-template into feature/321_Migrate_e-date_c-date-picker
patric-eberle
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request
This PR brings two new features to the form:
I've also included new translation strings into
de.json+ a new dependency package calledpikaday.Before testing, please run
npm installornpm cito ensure that the package is installed.Ticket
http://localhost:5173/styleguide/sandbox/forms
Browser testing
#321
Checklist
Review/Test checklist