Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#322 e-table enhancements #360

Merged
merged 7 commits into from
Apr 17, 2024
Merged

#322 e-table enhancements #360

merged 7 commits into from
Apr 17, 2024

Conversation

patric-eberle
Copy link
Member

@patric-eberle patric-eberle commented Jan 19, 2024 •
edited by mob8607
Loading

Pull request

This PR applies some small improvements to the e-table component based on the changes from SF. I decided to not make a 1:1 copy, because some changes from that project seem to be too specific.

Ticket

#322

Browser testing

Checklist

  • I merged the current development branch (before testing)
  • Added JSDoc and styleguide demo
  • Tested all links in project relevant browsers
  • Tested all links in different screen sizes
  • Did run automated tests and linters
  • Did assign ticket
  • Double checked target branch

Review/Test checklist

  • Did review code and documentation
  • Tested all links in project relevant browsers
  • Tested all links in different screen sizes
  • Did check accessibility (Wave, only errors)
  • Re-assign ticket to developer

@patric-eberle patric-eberle added the enhancement New feature or request label Jan 19, 2024
@patric-eberle patric-eberle requested review from BeneRichi and MB-web and removed request for BeneRichi January 19, 2024 10:04
@patric-eberle patric-eberle assigned MB-web and unassigned BeneRichi Jan 24, 2024
@patric-eberle
Copy link
Member Author

@MB-web would be nice if you could also check this PR.

mob8607
mob8607 requested changes Jan 29, 2024
View reviewed changes
Copy link
Collaborator

@mob8607 mob8607 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good 👍

Browser Review:

In Safari there seems to be a styling issue. There is an additional borders in each row:
Bildschirmfoto 2024-01-29 um 14 25 45

@mob8607 mob8607 changed the base branch from develop to master April 17, 2024 08:34
@mob8607 mob8607 merged commit 639af5f into master Apr 17, 2024
@mob8607 mob8607 deleted the feature/#322_e-table-enhancements branch April 17, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mob8607 mob8607 mob8607 approved these changes

@MB-web MB-web Awaiting requested review from MB-web

Assignees

@MB-web MB-web

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@patric-eberle @mob8607 @BeneRichi @MB-web