Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolving the on-going issues with Jasmin permissions. #115

Merged
merged 1 commit into from
Nov 2, 2023

Conversation

ledm
Copy link
Collaborator

@ledm ledm commented Nov 2, 2023

Resolving the on-going issues with Jasmin permissions.

Continues from the merged #114.

@valeriupredoi valeriupredoi added bug Something isn't working enhancement New feature or request labels Nov 2, 2023
Copy link
Owner

@valeriupredoi valeriupredoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍻

@valeriupredoi valeriupredoi merged commit 836729d into main Nov 2, 2023
1 check passed
@valeriupredoi
Copy link
Owner

am also deleting the branch, hopefully no more need for it, if not, jyst create a new one, bud - this has been a tricky one!

@valeriupredoi valeriupredoi deleted the fix_auto_download_permissions branch November 2, 2023 12:49
@ledm
Copy link
Collaborator Author

ledm commented Nov 2, 2023

Yeah, hopefully we can put this one to bed now. But I suspect that it's not over yet.

@ledm
Copy link
Collaborator Author

ledm commented Nov 2, 2023

I was right. Something else is broken here.

@ledm
Copy link
Collaborator Author

ledm commented Nov 2, 2023

We never considered looking at a new job! We're checking permissions of a file that doesn't exist yet and it fails. I'll write a fix now.

@valeriupredoi
Copy link
Owner

isn't there a check on outFolder's existence somewhere up the stack? I could swear I saw one

@ledm
Copy link
Collaborator Author

ledm commented Nov 2, 2023

No check, I've added this fix to the PR in #116.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants