Added a new subpolar North Atlantic region (SPNA) #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ledm
commented
Mar 26, 2024
valeriupredoi
approved these changes
Mar 26, 2024
|
Okay, thanks! Merging. Now is probably a good time for @DrYool to update his code with the main branch: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm adding a new subpolar North Atlantic region (SPNA), but while doing so, I found that there's a couple inefficiencies in the data loader.
This patch makes it much more efficient to load data as it now. Previously, if a single region or layer was missing, then all layers and regions were re-loaded. Now it checked whether the full permutation of all
(region, layers, metrics)exists, and only loads the missing ones.BTW, the SPNA is 35 W to 10 W, 40N to 65N. It's an interesting region for climate change! It's going to go into all the default UKESM analyses from now. Currently testing it in Temperature.yml.
This PR requires PR #126 to be completed.