Outputs comparison suite data to json and AtmosCO2 #129
Conversation
… into dev_plot2csv
|
The tests arefailing because I added a new import: |
|
this the package you added? https://anaconda.org/conda-forge/jsondiff |
|
Looks like that works, good job V. |
|
no failed test can ever stand a chance against me, bud 😁 |
bgcval2/analysis_compare.py
Outdated
| details['dpi'] = input_yml_dict.get('dpi', None) | ||
| details['savepdf'] = input_yml_dict.get('savepdf', False) | ||
| details['savecsv'] = input_yml_dict.get('savecsv', False) |
There was a problem hiding this comment.
Probably worth adding this functionality into documentation.
There was a problem hiding this comment.
Thinking about it, maybe it should be savejson, instead of savecsv?
There was a problem hiding this comment.
no IMHO since json is just the transport/payload, CSV is the final format no?
There was a problem hiding this comment.
The final files are json format. It's basically a human readable python dictionary. Kinda like a shelve file that isn't a weird format.
There was a problem hiding this comment.
human-readable and json are not sitting well on the same bus, bud 😆
There was a problem hiding this comment.
Too late! Changed it to json!
There was a problem hiding this comment.
whatever you think best, man - am merely devops here 😀
|
Ready for review @valeriupredoi! |
on it right now, buds 🍺 |
| title=title, | ||
| ts=ts, | ||
| csvFolder=csvFolder) | ||
|
|
There was a problem hiding this comment.
gets the prize for the function with most number of args I've seen 😁
|
|
||
| """ | ||
| if csvformat.lower() not in ['json', '.json']: | ||
| print('Format not set up', csvformat ) |
There was a problem hiding this comment.
| print('Format not set up', csvformat ) | |
| print('Looking for a json or .json file extension. Format not set up', csvformat ) |
There was a problem hiding this comment.
yeah if you need it to exit right away, maybe OSError instead? TypeError refers to a type of a Python(-already) object that can not be operated on
|
Okay - all good here. Happy to merge @valeriupredoi. |
Two major changes: