Several developments for the AMOC analysis #132
Conversation
|
The test is failing because I added the |
| print('NorthAtlanticOcean - pre') | ||
| #xx = bvt.makeLonSafeArr(xx) | ||
| print('NorthAtlanticOcean', len(xx)) |
There was a problem hiding this comment.
| print('NorthAtlanticOcean - pre') | |
| #xx = bvt.makeLonSafeArr(xx) | |
| print('NorthAtlanticOcean', len(xx)) |
There was a problem hiding this comment.
yo can you maybe not do development in review mode, pls bud? I get an email everytime you "suggest" a change 🤣
There was a problem hiding this comment.
Github is annoying like that. I was told there's a setting somewhere that reduces the number of emails. I don't believe it personally.
I think it's tested against that file, let me see |
| # mx *= np.ma.masked_outside(xx, -45., 15.).mask + np.ma.masked_outside( | ||
| # xy, 60., 80.).mask |
There was a problem hiding this comment.
| # mx *= np.ma.masked_outside(xx, -45., 15.).mask + np.ma.masked_outside( | |
| # xy, 60., 80.).mask |
| # mx *= np.ma.masked_outside(xx, -45., 15.).mask + np.ma.masked_outside( | ||
| # xy, 60., 80.).mask |
There was a problem hiding this comment.
| # mx *= np.ma.masked_outside(xx, -45., 15.).mask + np.ma.masked_outside( | |
| # xy, 60., 80.).mask |
| # if newSlice in ['WesternSubpolarNorthAtlantic', 'WSPNA',]: | ||
|
|
||
|
|
There was a problem hiding this comment.
| # if newSlice in ['WesternSubpolarNorthAtlantic', 'WSPNA',]: | |
|
yep, just add the "500m" member in the list here |
|
@ledm you ready for this to be merged? All fine by me 👍 |
This includes several developments for the AMOC analysis: