Changes around the default argocd policy #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We do two main changes: 1. We set the `defaultPolicy` to `role:readonly`. This allows any authenticated user to see the the argo applications 2. We add a `g, admin, role:admin` and make sure that we get the `email` scope from the OIDC as well. This allows the RHDP user `admin` to work out of the box. Tested as follows: 1. Logged in on the clusterwide argo as kube admin and could still see all apps and could refresh/sync 2. Logged in as htpasswd user foo and could see the apps in read-only and could not sync 3. Logged in as htpasswd user admin and could see the apps and could sync/refresh them Co-Authored-By: Akos Eros <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We do two main changes:
defaultPolicytorole:readonly. This allows anyauthenticated user to see the the argo applications
g, admin, role:adminand make sure that we get theemailscope from the OIDC as well. This allows the RHDP user
admintowork out of the box.
Tested as follows:
and could refresh/sync
not sync
sync/refresh them
Co-Authored-By: Akos Eros [email protected]