Skip to content

Commit

Permalink
Merge pull request #312 from mbaldessari/quick-fixes
Browse files Browse the repository at this point in the history
Some fixes
  • Loading branch information
mbaldessari authored Nov 27, 2024
2 parents d833693 + 3eb33d2 commit dd15423
Show file tree
Hide file tree
Showing 4 changed files with 13 additions and 4 deletions.
6 changes: 3 additions & 3 deletions tests/interop/test_check_logging_hub.py
Original file line number Diff line number Diff line change
Expand Up @@ -50,11 +50,11 @@ def test_check_logging_hub():
logger.info(
"Checking logs for anomaly-detection-predictor in manuela-tst-all" " namespace"
)
app_string = "seldon-app=anomaly-detection-predictor"
app_string = "modelmesh-service=modelmesh-serving"
log_out = get_log_output(
app_string, namespace="manuela-tst-all", container="anomaly-detection"
app_string, namespace="manuela-tst-all", container="mlserver"
)
search_terms = ["Predict"]
search_terms = ["/inference.GRPCInferenceService/ModelInfer"]
if not search_log_output(log_out, search_terms):
err_msg = "Failed to find expected output in anomaly-detection-predictor log"
logger.error(f"FAIL: {err_msg}")
Expand Down
4 changes: 4 additions & 0 deletions tests/interop/test_toggle_machine_sensor.py
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,10 @@
oc = os.environ["HOME"] + "/oc_client/oc"


# FIXME(bandini): For now we skip this test, we need to rewrite it so that the change pushed in git
# is done in the in-cluster gitea and not on the upstream repo. Otherwise the change will never be
# propagated
@pytest.mark.skip(reason="Need to push the changes to the in-cluster gitea")
@pytest.mark.toggle_machine_sensor
def test_toggle_machine_sensor(openshift_dyn_client):
logger.info("Testing machine-sensor config change")
Expand Down
2 changes: 1 addition & 1 deletion tests/interop/test_validate_pipelineruns.py
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ def test_validate_pipelineruns(openshift_dyn_client):
"build-and-test-iot-anomaly-detection",
"build-and-test-iot-consumer",
"build-and-test-iot-frontend",
"build-and-test-iot-software-sensor"
"build-and-test-iot-software-sensor",
]

expected_pipelineruns = [
Expand Down
5 changes: 5 additions & 0 deletions values-factory.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,11 @@ clusterGroup:
path: charts/factory/manuela-stormshift
extraValueFiles:
- /overrides/values-prod-imagedata.yaml
ignoreDifferences:
- group: image.openshift.io
kind: ImageStream
jsonPointers:
- /spec/tags


#
Expand Down

0 comments on commit dd15423

Please sign in to comment.