Skip to content

Disable validate_origin if a token_secret is set #467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mbaldessari merged 3 commits into from
Sep 18, 2025
Merged

Disable validate_origin if a token_secret is set #467

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b1663ad
Disable validate_origin if a token_secret is set
mbaldessari Sep 18, 2025
f5f3d01
Merge pull request #635 from mbaldessari/simpler-validation
mbaldessari Sep 18, 2025
dd8cea4
Merge remote-tracking branch 'common-upstream/main' into common-autom…
mbaldessari Sep 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 12 additions & 8 deletions common/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,14 +4,6 @@ ifneq ($(origin TARGET_SITE), undefined)
TARGET_SITE_OPT=--set main.clusterGroupName=$(TARGET_SITE)
endif

# Set this to true if you want to skip any origin validation
DISABLE_VALIDATE_ORIGIN ?= false
ifeq ($(DISABLE_VALIDATE_ORIGIN),true)
VALIDATE_ORIGIN :=
else
VALIDATE_ORIGIN := validate-origin
endif

# This variable can be set in order to pass additional helm arguments from the
# the command line. I.e. we can set things without having to tweak values files
EXTRA_HELM_OPTS ?=
Expand Down Expand Up @@ -48,6 +40,18 @@ endif
TOKEN_SECRET ?=
TOKEN_NAMESPACE ?= openshift-operators

# Set this to true if you want to skip any origin validation
# if TOKEN_SECRET is set to something then we skip the validation as well
DISABLE_VALIDATE_ORIGIN ?= false
ifeq ($(DISABLE_VALIDATE_ORIGIN),true)
VALIDATE_ORIGIN :=
else ifneq ($(TOKEN_SECRET),)
VALIDATE_ORIGIN :=
else
VALIDATE_ORIGIN := validate-origin
endif


ifeq ($(TOKEN_SECRET),)
# SSH agents are not created for public repos (repos with no secret token) by the patterns operator so we convert to HTTPS
TARGET_REPO := $(shell echo "$(TARGET_REPO_RAW)" | sed 's/^git@\(.*\):\(.*\)/https:\/\/\1\/\2/')
Expand Down