Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update common #96

Merged
merged 117 commits into from
Jul 8, 2023
Merged

Update common #96

merged 117 commits into from
Jul 8, 2023

Commits on Mar 21, 2023

  1. Configuration menu
    Copy the full SHA
    1cb3f09 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e68b7d9 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    8aa8396 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    6b55045 View commit details
    Browse the repository at this point in the history
  5. Updating CI tests

    claudiol committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    7565648 View commit details
    Browse the repository at this point in the history
  6. Fixed Markdown errors

    claudiol committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    185d11a View commit details
    Browse the repository at this point in the history

Commits on Apr 21, 2023

  1. - Added functionality to support the following format for labels and …

    …annotations:
    
          labels:
            openshift.io/node-selector: ""
          annotations:
            openshift.io/cluster-monitoring: "true"
    claudiol committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    d3b6faf View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3c60aa1 View commit details
    Browse the repository at this point in the history
  3. Fixed CI Issues

    claudiol committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    9d6fc02 View commit details
    Browse the repository at this point in the history

Commits on Apr 27, 2023

  1. Avoid exited containers proliferation

    When running the `pattern.sh` script multiple times, a lot of
    podman exited containers will be left on the machine, adding
    `--rm` parameter to `podman run` makes podman automatically
    delete the exited containers leaving the machine cleaner.
    Lorenzo Dalrio committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    d1cf543 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #302 from beelzetron/feature/clean-podman-exited-c…

    …ontainers
    
    Avoid exited containers proliferation using pattern.sh script
    mbaldessari authored Apr 27, 2023
    Configuration menu
    Copy the full SHA
    cc44bff View commit details
    Browse the repository at this point in the history

Commits on Apr 28, 2023

  1. Handling of pre-release builds is too complex for a helm chart

    Generating the ICSP and allowing insecure registries is best done prior
    to helm upgrade, and requires VPN access to registry-proxy.engineering.redhat.com
    beekhof committed Apr 28, 2023
    Configuration menu
    Copy the full SHA
    37c8f3a View commit details
    Browse the repository at this point in the history

Commits on May 3, 2023

  1. Configuration menu
    Copy the full SHA
    d6b2b0d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3c81c48 View commit details
    Browse the repository at this point in the history
  3. Adding CI test

    claudiol committed May 3, 2023
    Configuration menu
    Copy the full SHA
    fa9f2dc View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    a0e2d91 View commit details
    Browse the repository at this point in the history
  5. Updating CI issues

    claudiol committed May 3, 2023
    Configuration menu
    Copy the full SHA
    3f6d9b5 View commit details
    Browse the repository at this point in the history

Commits on May 5, 2023

  1. Configuration menu
    Copy the full SHA
    6566688 View commit details
    Browse the repository at this point in the history

Commits on May 10, 2023

  1. Merge pull request #283 from claudiol/namespace-additional-properties

    WIP: Add labels and annotations support for namespaces (RFE)
    mbaldessari authored May 10, 2023
    Configuration menu
    Copy the full SHA
    b855239 View commit details
    Browse the repository at this point in the history

Commits on May 15, 2023

  1. Allow overriding the pattern's name

    This is especially useful when multiple people are working on a pattern
    an have been using different names:
    
        $ make help |grep Pattern:
        Pattern: multicloud-gitops
        $ make NAME=foobar help |grep Pattern:
        Pattern: foobar
    mbaldessari committed May 15, 2023
    Configuration menu
    Copy the full SHA
    c7dadbf View commit details
    Browse the repository at this point in the history
  2. Merge pull request #303 from mbaldessari/name

    Allow overriding the pattern's name
    mhjacks authored May 15, 2023
    Configuration menu
    Copy the full SHA
    7ccd29c View commit details
    Browse the repository at this point in the history

Commits on May 16, 2023

  1. Configuration menu
    Copy the full SHA
    a6bb073 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ea7186e View commit details
    Browse the repository at this point in the history
  3. Add an item to README.md

    mbaldessari committed May 16, 2023
    Configuration menu
    Copy the full SHA
    c09126f View commit details
    Browse the repository at this point in the history
  4. Fix up common/ tests

    mbaldessari committed May 16, 2023
    Configuration menu
    Copy the full SHA
    70b778c View commit details
    Browse the repository at this point in the history
  5. Fix super linter

    mbaldessari committed May 16, 2023
    Configuration menu
    Copy the full SHA
    ee59eee View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    07acbc3 View commit details
    Browse the repository at this point in the history

Commits on May 18, 2023

  1. Set gitOpsSpec.operatorSource

    After merging validatedpatterns/patterns-operator@235b303
    it is now effectively possible to pick a different catalogSource for
    the gitops operator. This is needed in order to allow CI to install
    the gitops operator from an IIB
    mbaldessari committed May 18, 2023
    Configuration menu
    Copy the full SHA
    0e661bf View commit details
    Browse the repository at this point in the history
  2. Introduce EXTRA_HELM_OPTS

    This variable can be set in order to pass additional helm arguments from the
    the command line. I.e. we can set things without having to tweak values files
    So it is now possible to run something like the following:
    
      ./pattern.sh make install \
      EXTRA_HELM_OPTS="--set main.gitops.operatorSource=iib-49232"
    mbaldessari committed May 18, 2023
    Configuration menu
    Copy the full SHA
    d9db633 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    8bfb05d View commit details
    Browse the repository at this point in the history
  4. Merge pull request #306 from mbaldessari/catalogsource

    catalgSource fixes
    mbaldessari authored May 18, 2023
    Configuration menu
    Copy the full SHA
    2fff431 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    b4e5967 View commit details
    Browse the repository at this point in the history
  6. Simplify load-iib target

    mbaldessari committed May 18, 2023
    Configuration menu
    Copy the full SHA
    5cbc2c0 View commit details
    Browse the repository at this point in the history
  7. Add templates folder

    mbaldessari committed May 18, 2023
    Configuration menu
    Copy the full SHA
    bb97c58 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    65dda37 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    4dfeecb View commit details
    Browse the repository at this point in the history
  10. Skip the iib-ci playbook

    mbaldessari committed May 18, 2023
    Configuration menu
    Copy the full SHA
    33dfdb3 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    93fd8c8 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    6263afe View commit details
    Browse the repository at this point in the history
  13. Add help for load-iib

    mbaldessari committed May 18, 2023
    Configuration menu
    Copy the full SHA
    c776ed0 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    b6b4836 View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    51b9fb4 View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    7567a73 View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    ff6b73f View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    7dfa5cf View commit details
    Browse the repository at this point in the history
  19. Configuration menu
    Copy the full SHA
    5e51a63 View commit details
    Browse the repository at this point in the history
  20. Configuration menu
    Copy the full SHA
    1b80705 View commit details
    Browse the repository at this point in the history
  21. Configuration menu
    Copy the full SHA
    aef9717 View commit details
    Browse the repository at this point in the history
  22. Configuration menu
    Copy the full SHA
    14209b3 View commit details
    Browse the repository at this point in the history
  23. Configuration menu
    Copy the full SHA
    7d17348 View commit details
    Browse the repository at this point in the history
  24. Also allow gchr.io

    mbaldessari committed May 18, 2023
    Configuration menu
    Copy the full SHA
    dbdbc8c View commit details
    Browse the repository at this point in the history
  25. Revert "Test dropping nevercontact source"

    This reverts commit d8746a37fce2663018f52203c892f00b825e32a7.
    mbaldessari committed May 18, 2023
    Configuration menu
    Copy the full SHA
    0355fa4 View commit details
    Browse the repository at this point in the history
  26. Fix typo

    mbaldessari committed May 18, 2023
    Configuration menu
    Copy the full SHA
    47855e0 View commit details
    Browse the repository at this point in the history
  27. Configuration menu
    Copy the full SHA
    49f018a View commit details
    Browse the repository at this point in the history
  28. Configuration menu
    Copy the full SHA
    d1dc09f View commit details
    Browse the repository at this point in the history
  29. Configuration menu
    Copy the full SHA
    729232a View commit details
    Browse the repository at this point in the history
  30. Configuration menu
    Copy the full SHA
    d4eb914 View commit details
    Browse the repository at this point in the history
  31. Configuration menu
    Copy the full SHA
    f73f75d View commit details
    Browse the repository at this point in the history
  32. Also whitelist ghcr.io

    mbaldessari committed May 18, 2023
    Configuration menu
    Copy the full SHA
    b660f93 View commit details
    Browse the repository at this point in the history
  33. Fetch the operator bundle itself in a more robust way

    It seems that the operator bundle image itself is nowhere to be found
    inside any OCP cluster object (it's not in packagemanifests nor
    catalogsource). Resorting to parsing the IIB via opm alpha commands
    to fetch the exact image.
    mbaldessari committed May 18, 2023
    Configuration menu
    Copy the full SHA
    41dc747 View commit details
    Browse the repository at this point in the history
  34. Add more mirrors

    mbaldessari committed May 18, 2023
    Configuration menu
    Copy the full SHA
    2a941fb View commit details
    Browse the repository at this point in the history

Commits on May 19, 2023

  1. Configuration menu
    Copy the full SHA
    a4e232b View commit details
    Browse the repository at this point in the history
  2. Cleanup spacing

    mbaldessari committed May 19, 2023
    Configuration menu
    Copy the full SHA
    45912f1 View commit details
    Browse the repository at this point in the history
  3. Fix super-linter

    mbaldessari committed May 19, 2023
    Configuration menu
    Copy the full SHA
    86ac7c2 View commit details
    Browse the repository at this point in the history
  4. Move task in right folder

    mbaldessari committed May 19, 2023
    Configuration menu
    Copy the full SHA
    d713e7b View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    09e5389 View commit details
    Browse the repository at this point in the history
  6. Merge pull request #305 from mbaldessari/iib

    IIB Support
    mbaldessari authored May 19, 2023
    Configuration menu
    Copy the full SHA
    f4b54ae View commit details
    Browse the repository at this point in the history

Commits on May 22, 2023

  1. Improve the grepping for the operator bundle

    Without also grepping for the default_channel we can end up getting
    multiple results, which breaks everything.
    
    Tested this and it fixed the issue I was seeing with the
    openshift-gitops-operator this morning
    mbaldessari committed May 22, 2023
    Configuration menu
    Copy the full SHA
    45a5e25 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #307 from mbaldessari/fix-iib1

    Improve the grepping for the operator bundle
    mbaldessari authored May 22, 2023
    Configuration menu
    Copy the full SHA
    8239ea4 View commit details
    Browse the repository at this point in the history
  3. Drop display_skipped_hosts

    display_skipped_hosts=False has a horrible side-effect:
    When a task takes a long time, it is always the *next* task and not the
    one printed on the screen/log. That is because ansible has to wait for
    the task to finish before printing it as it does not know before hand if
    the host will be skipped and hence the task should not be displayed at
    all
    mbaldessari committed May 22, 2023
    Configuration menu
    Copy the full SHA
    3c29969 View commit details
    Browse the repository at this point in the history
  4. Merge pull request #308 from mbaldessari/ansible-cfg

    Drop display_skipped_hosts
    mbaldessari authored May 22, 2023
    Configuration menu
    Copy the full SHA
    65c512a View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    ff1eacf View commit details
    Browse the repository at this point in the history
  6. Upgrade ESO to v0.8.2

    mbaldessari committed May 22, 2023
    Configuration menu
    Copy the full SHA
    44f6d57 View commit details
    Browse the repository at this point in the history
  7. Update README.md

    mbaldessari committed May 22, 2023
    Configuration menu
    Copy the full SHA
    06698b3 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    9abbef7 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    b0e08e0 View commit details
    Browse the repository at this point in the history
  10. Move to new spec format for dex/sso

    Via https://issues.redhat.com/browse/GITOPS-2761 we are told that the
    dex configuration has a new format.
    Old format:
    
        spec:
          dex:
            openShiftOAuth: true
            resources:
            ...
    
    New format:
    
        spec:
          sso:
            provider: dex
            dex:
              openShiftOAuth: true
              resources:
              ...
    
    This format is only supported starting with gitops-1.8.0, so we should
    merge this only when we are absolutely sure that no pattern in no
    situation needs an older gitops version.
    
    Tested on MCG with gitops-1.8.2
    
    Note: with this change gitops < 1.8 is not supported. Starting with
    gitops-1.9 the old format will be unsupported.
    mbaldessari committed May 22, 2023
    Configuration menu
    Copy the full SHA
    f672950 View commit details
    Browse the repository at this point in the history
  11. Disable ArgoCD from kubeconform

    The reason is that most of the tools we used to generate the json
    schema, seem to be unmaintained, so it is getting hard to update
    our schemas in our GH org. We'll need to revisit this in the future.
    mbaldessari committed May 22, 2023
    Configuration menu
    Copy the full SHA
    8ed17fc View commit details
    Browse the repository at this point in the history
  12. Merge pull request #290 from mbaldessari/modernize-argo-sso

    Move to new spec format for dex/sso
    mbaldessari authored May 22, 2023
    Configuration menu
    Copy the full SHA
    460cc67 View commit details
    Browse the repository at this point in the history

Commits on May 24, 2023

  1. Configuration menu
    Copy the full SHA
    bf56440 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #310 from mbaldessari/readme-iib

    Add a short line about username/token for the iib role on OCP <= 4.12
    mbaldessari authored May 24, 2023
    Configuration menu
    Copy the full SHA
    576c246 View commit details
    Browse the repository at this point in the history
  3. Drop https:// from podman login

    Seems we hit https://www.github.com/containers/podman/issues/13691 at
    least with older podman versions.
    
    If this turns out to break podman 4.5.0 I will special case it later
    mbaldessari committed May 24, 2023
    Configuration menu
    Copy the full SHA
    dfc504e View commit details
    Browse the repository at this point in the history
  4. Merge pull request #311 from mbaldessari/podman-version-

    Drop https:// from podman login
    mbaldessari authored May 24, 2023
    Configuration menu
    Copy the full SHA
    e01dcda View commit details
    Browse the repository at this point in the history

Commits on May 25, 2023

  1. Set the mce-subscription-spec annotation

    We set it by default to "redhat-operators" and if defined to .Values.clusterGroup.subscriptions.acm.source
    The reason we do this is the following:
    1. In a default deployment scenario MCE has to be deployed as normal
       from the redhat-operators catalogSource just as ACM is
    2. When we deploy gitops-operator from an IIB instead, MCE would be
       installed trying to get it from the IIB because
       https://www.github.com/stolostron/multiclusterhub-operator/pull/975
       made it so that it picks the latest version looking at all catalog
       sources. But since we only mirrored the gitops operator in the
       cluster, this breaks as the images for MCE from the IIB are not there
       By setting the default to "redhat-operators" we fix this case
    3. Now in the case where we want to install ACM from an IIB we need to
       be able to override this and we will pick whatever value is set in
       .Values.clusterGroup.subscriptions.acm.source, which will need to be
       defined for this to work when testing ACM+MCE from an IIB
    
    Note: Currently point 3. works only if you set it in a values file.
    Setting .Values.clusterGroup.subscriptions.acm.source via extraParams
    won't be passed down from the clusterGroup app to the applications.
    It's a bug that we need to fix.
    
    Note(2): We surround this with an 'if kindIs "map" .Values.clusterGroup.subscriptions'
    because we do not want to break things if subscription is a list and not
    a map. If we ever manage to drop subscriptions as list, then we can
    remove that if
    mbaldessari committed May 25, 2023
    Configuration menu
    Copy the full SHA
    1edf4da View commit details
    Browse the repository at this point in the history
  2. Merge pull request #312 from mbaldessari/mce-sub

    Set the mce-subscription-spec annotation
    mbaldessari authored May 25, 2023
    Configuration menu
    Copy the full SHA
    240d04b View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    5396871 View commit details
    Browse the repository at this point in the history
  4. Simplify the README a bit

    mbaldessari committed May 25, 2023
    Configuration menu
    Copy the full SHA
    058d5c6 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    e20c287 View commit details
    Browse the repository at this point in the history

Commits on May 30, 2023

  1. Add support for extraParams being passed down to all applications

    Via validatedpatterns/patterns-operator#74
    we add the extraParams in an extraParametersNested dictionary that holds
    the extraParams key/value pairs. If they exist, let's add them as
    parameters.
    
    This allows them to end up in the applications.
    mbaldessari committed May 30, 2023
    Configuration menu
    Copy the full SHA
    0432536 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #314 from mbaldessari/fix-extraparams

    Add support for extraParams being passed down to all applications
    mbaldessari authored May 30, 2023
    Configuration menu
    Copy the full SHA
    bb8e98b View commit details
    Browse the repository at this point in the history

Commits on Jun 1, 2023

  1. Configuration menu
    Copy the full SHA
    48126e7 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #315 from mbaldessari/lookup

    Add a lookup playbook to figure out IIB numbers
    mbaldessari authored Jun 1, 2023
    Configuration menu
    Copy the full SHA
    ff8bea5 View commit details
    Browse the repository at this point in the history
  3. Allow overriding channel and source when installing the patterns-oper…

    …ator
    
    This will allow us to test the patterns-operator using a different
    catalogsource (potentially installed via an IIB). So we can run:
    
    make EXTRA_HELM_OPTS="\
      --set main.extraParameters[0].name=main.patternsOperator.channel --set main.extraParameters[0].value=slow \
      --set main.extraParameters[1].name=main.patternsOperator.source --set main.extraParameters[1].value=patten-index" install
    mbaldessari committed Jun 1, 2023
    Configuration menu
    Copy the full SHA
    b1070a1 View commit details
    Browse the repository at this point in the history

Commits on Jun 2, 2023

  1. Merge pull request #316 from mbaldessari/pattern-index

    Allow overriding channel and source when installing the patterns-operator
    mbaldessari authored Jun 2, 2023
    Configuration menu
    Copy the full SHA
    35f79c0 View commit details
    Browse the repository at this point in the history

Commits on Jun 6, 2023

  1. Configuration menu
    Copy the full SHA
    8f3c407 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #317 from mbaldessari/fixtypo1

    Fix small typo in iib instructions
    mbaldessari authored Jun 6, 2023
    Configuration menu
    Copy the full SHA
    b6ee6ed View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2023

  1. Configuration menu
    Copy the full SHA
    6116964 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #318 from mbaldessari/drop-iib-log

    Drop a redirect and up retries when pushing the IIB to the internal registry
    mbaldessari authored Jun 7, 2023
    Configuration menu
    Copy the full SHA
    6923648 View commit details
    Browse the repository at this point in the history

Commits on Jun 15, 2023

  1. Update ESO to v0.8.3

    mbaldessari committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    6e6f258 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #319 from mbaldessari/eso-0.8.3

    Update ESO to v0.8.3
    mbaldessari authored Jun 15, 2023
    Configuration menu
    Copy the full SHA
    18d2ac2 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    2797699 View commit details
    Browse the repository at this point in the history
  4. Add tests

    mbaldessari committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    ab5532a View commit details
    Browse the repository at this point in the history
  5. Fix image and comment

    mbaldessari committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    d4d3fe1 View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2023

  1. Configuration menu
    Copy the full SHA
    598bc74 View commit details
    Browse the repository at this point in the history
  2. Make Test

    day0hero committed Jun 26, 2023
    Configuration menu
    Copy the full SHA
    64e9dc7 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    e296fb0 View commit details
    Browse the repository at this point in the history

Commits on Jul 7, 2023

  1. Revert "Make Test"

    This reverts commit 64e9dc7.
    mbaldessari committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    1895a73 View commit details
    Browse the repository at this point in the history
  2. Revert "Adding rbac to support the vault sa checking on the vault-0 p…

    …od status."
    
    This reverts commit 598bc74.
    mbaldessari committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    08eee55 View commit details
    Browse the repository at this point in the history
  3. Revert "Fix image and comment"

    This reverts commit d4d3fe1.
    mbaldessari committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    c5aa3d2 View commit details
    Browse the repository at this point in the history
  4. Revert "Add tests"

    This reverts commit ab5532a.
    mbaldessari committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    6d4a481 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    3bf245b View commit details
    Browse the repository at this point in the history
  6. Increase the default retry limit when syncing

    ArgoCD will retry 5 times by default to sync an application in case of
    errors and then will give up. So if an application contains a reference
    to a CRD that has not been installed yet (say because it will be
    installed by another application), it will error out and retry later.
    This happens by default for a maximum of 5 times [1]. After those 5 times
    the application will give up and will stay in Degraded moded and
    eventually move to Failed. In this case a manual sync will usually fix
    the application just fine (i.e. as long as the missing CRD has been
    installed in the meantime).
    
    Now to solve this issue we can add complex preSync Jobs that wait for
    the needed resources, but this fundamentally breaks the simplicity of
    things and introduces unneeded dependencies. In this change we just
    increase the default retry limit to something larger (20) that should
    cover most cases. The retry limit functionality is rather undocumented
    currently in the docs but is defined at [2] and also shown at [3].
    
    In our patterns' case the concrete issue happened as follows:
    1. ESO ClusterSecrets were often not synced/degraded
    2. We introduced a Job in a preSync hook for the ESO chart that would
       wait on vault to be ready before applying the rest of ESO
    3. MCG started failing because the config-demo app had already tried to
       sync 5 times and failed everytime because the ESO CRDs were not
       installed yet (due to ESO waiting on vault)
    
    So instead of adding yet another job, let's just try a lot more often.
    We picked 20 as a sane default because that should have argo try for
    about 60 minutes (3min is the default maximum backoff limit)
    
    Tested with two MCG installations (with the ESO Job hook included) and
    both worked out of the box. Whereas before I managed to get three
    failures out of three installs.
    
    [1] https://github.com/argoproj/argo-cd/blob/master/controller/appcontroller.go#L1680
    [2] https://github.com/argoproj/argo-cd/blob/master/manifests/crds/application-crd.yaml#L1476
    [3] https://github.com/argoproj/argo-cd/blob/master/docs/operator-manual/application.yaml#L202C18-L202C100
    mbaldessari committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    0ae561b View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2023

  1. Add Changes.md entry

    mbaldessari committed Jul 8, 2023
    Configuration menu
    Copy the full SHA
    66d456d View commit details
    Browse the repository at this point in the history
  2. Merge pull request #323 from mbaldessari/retry-final

    Revert ESO/Vault Job and add a default higher number of retries
    mbaldessari authored Jul 8, 2023
    Configuration menu
    Copy the full SHA
    0c1d103 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    90cbc7e View commit details
    Browse the repository at this point in the history
  4. Add 'common/' from commit '0c1d103a064dbe7a9bd7049920acef607fc1abd8'

    git-subtree-dir: common
    git-subtree-mainline: 90cbc7e
    git-subtree-split: 0c1d103
    day0hero committed Jul 8, 2023
    Configuration menu
    Copy the full SHA
    d697b37 View commit details
    Browse the repository at this point in the history
  5. make test

    day0hero committed Jul 8, 2023
    Configuration menu
    Copy the full SHA
    aa97b37 View commit details
    Browse the repository at this point in the history