Merge pull request #19 from mbaldessari/fix-defaults

Fix defaults
validatedpatterns · Oct 1, 2024 · c6ffde9 · c6ffde9
2 parents c29df75 + 274745a
commit c6ffde9
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/.github/workflows/jsonschema.yaml b/.github/workflows/jsonschema.yaml
@@ -28,4 +28,4 @@ jobs:
       - name: Verify secrets json schema
         run: |
           set -e
-          for i in values-secret-v2-base values-secret-v2-generic-onlygenerate values-secret-v2-block-yamlstring; do echo "$i"; check-jsonschema --schemafile ./roles/vault_utils/values-secrets.v2.schema.json "tests/unit/v2/$i.yaml"; done
+          for i in values-secret-v2-base values-secret-v2-generic-onlygenerate values-secret-v2-block-yamlstring; do echo "$i"; check-jsonschema --fill-defaults --schemafile ./roles/vault_utils/values-secrets.v2.schema.json "tests/unit/v2/$i.yaml"; done
diff --git a/roles/vault_utils/values-secrets.v2.schema.json b/roles/vault_utils/values-secrets.v2.schema.json
@@ -276,12 +276,12 @@
          "base64": {
            "type": "boolean",
            "description": "Before uploading the secret the content is base-64 encoded. It is recommended to set this to true when dealing with files",
-           "default": "false"
+           "default": false
          },
          "override": {
            "type": "boolean",
            "description": "When onMissingValue is set to 'generate' and the secret already exists in the vault update it",
-           "default": "false"
+           "default": false
          }
       },
       "dependentRequired": {