Linting

.build/minify.js

@@ -11,12 +11,12 @@ function writeMinifiedFileSync(path, content, encding) {
 }
 
 
-// _glob
-//   .sync('./dist/bundle/**/*.js', [])
-//   .forEach(f => {
-//     console.log(_uglifyJS.minify(_fs.readFileSync(f, 'utf8'), {}))
-//     writeMinifiedFileSync(f, _uglifyJS.minify(_fs.readFileSync(f, 'utf8'), {
+_glob
+  .sync('./dist/bundle/**/*.js', [])
+  .forEach(f => {
+    // console.log(_uglifyJS.minify(_fs.readFileSync(f, 'utf8'), {}))
+    writeMinifiedFileSync(f, _uglifyJS.minify(_fs.readFileSync(f, 'utf8'), {
 
-//     }).code, 'utf8');
-//     console.log(`Minified "${f}"`);
-//   });
+    }).code, 'utf8');
+    console.log(`Minified "${f}"`);
+  });

.mocharc.yaml

@@ -7,8 +7,8 @@ recursive: true
 require:
   - ts-node/register # replace with ts-node/register/transpile-only if you have custom types
   - source-map-support/register
-bail: true
+bail: false
 color: true
-full-trace: true
+full-trace: false
 reporter: spec
 spec: test/**/*.spec.ts

package.json

@@ -18,18 +18,20 @@
     "rollup": "2.3.3",
     "source-map-support": "0.5.16",
     "ts-node": "8.8.2",
+    "tslint": "6.1.2",
     "typescript": "3.8.3",
     "uglify-js": "3.8.1"
   },
   "scripts": {
     "clean": "node ./.build/clean.js",
     "prebuild": "npm run clean",
     "build": "tsc --module es2015 && rollup --config ./rollup.config.js && node ./.build/minify.js",
-    "test": "nyc mocha",
+    "test": "npm run lint && nyc mocha",
     "predocs": "npm run test && npm run build",
     "docs": "rollup --config ./rollup.config.js --dir ./docs/demo/lib/bundle/",
     "predocs_dev": "npm run build",
-    "docs_dev": "rollup --config ./rollup.config.js --dir ./docs/demo/lib/bundle/"
+    "docs_dev": "rollup --config ./rollup.config.js --dir ./docs/demo/lib/bundle/",
+    "lint": "tslint --config ./tslint.json --project ./tsconfig.json --format stylish"
   },
   "repository": {
     "type": "git",

src/core/children/childComponent.ts

@@ -52,7 +52,7 @@ export abstract class ChildComponent extends Component {
    * Get the child component options.
    */
   protected getOptions(): ChildComponentOptions {
-    return <ChildComponentOptions>super.getOptions();
+    return super.getOptions() as ChildComponentOptions;
   }
 
   /**
@@ -64,7 +64,7 @@ export abstract class ChildComponent extends Component {
 
     this.setContentDisposePromise();
     // Inform parent the content is beeing disposed.
-    (<RootComponentFacade>this.rootFacade).signalDisposed(this);
+    (this.rootFacade as RootComponentFacade).signalDisposed(this);
   }
 
   /**
@@ -77,7 +77,7 @@ export abstract class ChildComponent extends Component {
     this.setContentDisposePromise();
 
     // This should trigger the child component dispose.
-    (<ContainerCommunicationHandler>this.communicationHandler).requestContentDispose();
+    (this.communicationHandler as ContainerCommunicationHandler).requestContentDispose();
   }
 
   /**
@@ -93,12 +93,12 @@ export abstract class ChildComponent extends Component {
           this
             .getWindow()
             .setTimeout(
-              () => rejectTimeout(new Error(`Child dispose timeout.`)),
+              () => rejectTimeout(new Error('Child dispose timeout.')),
               this.getOptions().contentDisposeTimeout
             );
         })
       ])
-      .catch((err) => {
+      .catch(err => {
         this.callErrorHandler(err);
       });
   }
@@ -110,7 +110,7 @@ export abstract class ChildComponent extends Component {
     if (this.contentDisposePromiseResolver === null) {
       // For some reason we got the disposed call without getting the 'beginDispose' call.
       this.contentDisposePromise = Promise.resolve();
-      (<RootComponentFacade>this.rootFacade).signalDisposed(this);
+      (this.rootFacade as RootComponentFacade).signalDisposed(this);
     } else {
       this.contentDisposePromiseResolver();
     }
@@ -132,9 +132,9 @@ export abstract class ChildComponent extends Component {
    */
   protected async disposeCore(): Promise<void> {
     this.startDisposingContent();
-    await (<Promise<void>>this.contentDisposePromise);
+    await (this.contentDisposePromise as Promise<void>);
 
-    (<ContainerCommunicationHandler>this.communicationHandler).dispose();
+    (this.communicationHandler as ContainerCommunicationHandler).dispose();
     this.communicationHandler = null;
     this.contentDisposePromiseResolver = null;
     this.contentDisposePromise = null;

src/core/children/childComponentFactory.ts

@@ -20,9 +20,9 @@ export class ChildComponentFactory {
       case ChildComponentType.InWindow:
         return new InWindowChildComponent(window, options, rootFacade);
       case ChildComponentType.CrossWindow:
-          return new CrossWindowChildComponent(window, <CrossWindowChildComponentOptions>options, rootFacade);
+          return new CrossWindowChildComponent(window, options as CrossWindowChildComponentOptions, rootFacade);
       default:
-        throw new Error(`The "${options.type}" is not configured.`)
+        throw new Error(`The "${options.type}" is not configured.`);
     }
   }
 }

src/core/children/communications/contentHandler.ts

@@ -75,6 +75,7 @@ export abstract class ContentCommunicationHandler {
    * Core dispose function.
    * Any component derived should override this to add clean-up after itself.
    */
+  // tslint:disable-next-line: no-empty
   protected disposeCore(): void { }
 
   /**

src/core/children/communications/event.ts

@@ -51,7 +51,7 @@ export class CommunicationsEvent {
    */
   constructor(kind: CommunicationsEventKind) {
     this.kind = kind;
-    this.uuid = getUuidV4()
+    this.uuid = getUuidV4();
     this.timestamp = new Date().getTime();
     this.contentId = '';
   }

src/core/children/communications/manager.ts

@@ -15,11 +15,13 @@ export abstract class CommunicationsManager {
   /**
    * Initialize the manager.
    */
+  // tslint:disable-next-line: no-empty
   protected initializeCore(): void { }
 
   /**
    * Clean any resources before the manager is disposed.
    */
+  // tslint:disable-next-line: no-empty
   protected disposeCore(): void { }
 
   /**
@@ -87,7 +89,7 @@ export abstract class CommunicationsManagerOf<TEndpoint> extends CommunicationsM
     this.outboundEndpoint = outboundEndpoint;
     this.outboundEventType = outboundEventType;
     this.onEventReceived = null;
-    this.eventHandler = (e: Event) => { this.handleEvent(e); }
+    this.eventHandler = (e: Event) => { this.handleEvent(e); };
   }
 
   /**
@@ -111,7 +113,7 @@ export abstract class CommunicationsManagerOf<TEndpoint> extends CommunicationsM
     if (this.inboundEndpoint && this.eventHandler) {
       this.startReceiving(this.inboundEndpoint, this.eventHandler);
     }
-    super.initializeCore()
+    super.initializeCore();
   }
 
   /**

src/core/children/crossWindow/childComponent.ts

@@ -42,11 +42,11 @@ export class CrossWindowChildComponent extends ChildComponent {
    */
   protected disposeCore(): Promise<void> {
     const embed = this.embededId
-      ? (<HTMLElement>this.rootElement).querySelector<HTMLIFrameElement>(`#${this.embededId}`)
+      ? (this.rootElement as HTMLElement).querySelector<HTMLIFrameElement>(`#${this.embededId}`)
       : null;
     if (embed) {
-      embed.removeEventListener('load', <() => void>this.embededLoadHandlerRef);
-      embed.removeEventListener('error', <(e: ErrorEvent) => void>this.embededErrorHandlerRef);
+      embed.removeEventListener('load', this.embededLoadHandlerRef as () => void);
+      embed.removeEventListener('error', this.embededErrorHandlerRef as (e: ErrorEvent) => void);
 
       // Do not remove the embeded element now as we still need it to comunicate with the content.
       // The parent "rootElement" will be removed latter anyhow.
@@ -64,7 +64,7 @@ export class CrossWindowChildComponent extends ChildComponent {
    * Get the CrossWindowChildComponentOptions
    */
   protected getOptions(): CrossWindowChildComponentOptions {
-    return <CrossWindowChildComponentOptions>super.getOptions();
+    return super.getOptions() as CrossWindowChildComponentOptions;
   }
 
   /**
@@ -74,7 +74,7 @@ export class CrossWindowChildComponent extends ChildComponent {
     const createEmbedElementFn = this.getOptions().createEmbedElement;
     let embed: HTMLElement | null = null;
     if (createEmbedElementFn) {
-      embed = createEmbedElementFn(<HTMLElement>this.rootElement);
+      embed = createEmbedElementFn(this.rootElement as HTMLElement);
     } else {
       embed = this.createEmbedElement();
     }
@@ -85,12 +85,12 @@ export class CrossWindowChildComponent extends ChildComponent {
     embed.id = embedId;
     this.embededId = embedId;
 
-    embed.addEventListener('load', <() => void>this.embededLoadHandlerRef);
-    embed.addEventListener('error', <(e: ErrorEvent) => void>this.embededErrorHandlerRef);
+    embed.addEventListener('load', this.embededLoadHandlerRef as () => void);
+    embed.addEventListener('error', this.embededErrorHandlerRef as (e: ErrorEvent) => void);
 
-    (<HTMLDivElement>this.rootElement).appendChild(embed);
+    (this.rootElement as HTMLDivElement).appendChild(embed);
 
-    await (<Promise<void>>(this.embededLoadPromise));
+    await ((this.embededLoadPromise) as Promise<void>);
 
     return await super.mountCore();
   }
@@ -102,7 +102,7 @@ export class CrossWindowChildComponent extends ChildComponent {
   protected getCommunicationHandlerCore(methods: ContainerCommunicationHandlerMethods): ContainerCommunicationHandler {
     const document = this.getDocument();
     const manager = new CrossWindowCommunicationsManager(
-      <Window>(document).defaultView,
+      (document).defaultView as Window,
       CommunicationsEvent.CONTENT_EVENT_TYPE,
       this.outboundEndpointAccesor(),
       CommunicationsEvent.CONTAINER_EVENT_TYPE,
@@ -121,15 +121,15 @@ export class CrossWindowChildComponent extends ChildComponent {
    * @param e The load event.
    */
   private embededLoadHandler(e: Event): void {
-    (<() => void>this.embededLoadResolver)();
+    (this.embededLoadResolver as () => void)();
   }
 
   /**
    * Handle the errir of the embeded element.
    * @param e The error event.
    */
   private embededErrorHandler(e: ErrorEvent): void {
-    (<(e: Error) => void>this.embededErrorRejecter)(new Error(`Failed to load embeded element.\nError details:\n${JSON.stringify(e)}`));
+    (this.embededErrorRejecter as (e: Error) => void)(new Error(`Failed to load embeded element.\nError details:\n${JSON.stringify(e)}`));
   }
 
   /**
@@ -140,9 +140,10 @@ export class CrossWindowChildComponent extends ChildComponent {
     const opt = this.getOptions();
     if (opt.embededAttributes) {
       const keys = Object.keys(opt.embededAttributes);
+      // tslint:disable-next-line: prefer-for-of
       for (let index = 0; index < keys.length; index++) {
         const key = keys[index];
-        embed.setAttribute(key, opt.embededAttributes[key])
+        embed.setAttribute(key, opt.embededAttributes[key]);
       }
     }
 
@@ -155,7 +156,7 @@ export class CrossWindowChildComponent extends ChildComponent {
    */
   private outboundEndpointAccesor(): Window {
     const embed = this.embededId
-      ? (<HTMLElement>this.rootElement).querySelector<HTMLIFrameElement>(`#${this.embededId}`)
+      ? (this.rootElement as HTMLElement).querySelector<HTMLIFrameElement>(`#${this.embededId}`)
       : null;
 
     if (!embed)

src/core/children/crossWindow/childComponentOptions.ts

@@ -7,7 +7,7 @@ import { ChildComponentType } from '../childComponentType';
 export class CrossWindowChildComponentOptions extends ChildComponentOptions {
   url: string = 'about:blank';
   createEmbedElement?: (el: HTMLElement) => HTMLElement;
-  embededAttributes?: { [key: string]: string; };
+  embededAttributes?: { [key: string]: string };
 
   /**
    * Constructor.

src/core/children/crossWindow/contentComunicationHandler.ts

@@ -6,7 +6,7 @@ import { CrossWindowCommunicationsManager } from '../communications/crossWindowM
  */
 export class CrossWindowContentCommunicationHandler extends ContentCommunicationHandler {
   private iframeId: string;
-  private messageQueue: Array<CommunicationsEvent>;
+  private messageQueue: CommunicationsEvent[];
 
   /**
    * Constructor.
@@ -87,6 +87,7 @@ export class CrossWindowContentCommunicationHandler extends ContentCommunication
    * Flush all the messages that were enqueues before the handhake.
    */
   private flushMessages(): void {
+    // tslint:disable-next-line: prefer-for-of
     for (let index = 0; index < this.messageQueue.length; index++) {
       const msg = this.messageQueue[index];
       msg.contentId = this.iframeId;

src/core/children/inWindow/childComponent.ts

@@ -22,7 +22,7 @@ export class InWindowChildComponent extends ChildComponent {
    * @inheritdoc
    */
   protected getCommunicationHandlerCore(methods: ContainerCommunicationHandlerMethods): ContainerCommunicationHandler {
-    const endpoint = <HTMLElement>this.rootElement;
+    const endpoint = this.rootElement as HTMLElement;
     const manager = new HTMLElementCommunicationsManager(
       endpoint,
       CommunicationsEvent.CONTENT_EVENT_TYPE,
@@ -37,7 +37,7 @@ export class InWindowChildComponent extends ChildComponent {
    * Get the InWindowChildComponentOptions
    */
   protected getOptions(): InWindowChildComponentOptions {
-    return <InWindowChildComponentOptions>super.getOptions();
+    return super.getOptions() as InWindowChildComponentOptions;
   }
 
   /**
@@ -48,7 +48,7 @@ export class InWindowChildComponent extends ChildComponent {
     if (!injectionFunction) {
       throw new Error('Inject method not defined!');
     }
-    injectionFunction(<HTMLElement>this.rootElement);
+    injectionFunction(this.rootElement as HTMLElement);
     await super.mountCore();
   }
 }