Skip to content

Commit

Permalink
Symbols: Reworked the symbol manager so that symbols don't need to be…
Browse files Browse the repository at this point in the history
… successfully downloaded in succession

- This should fix start menu not working (at all!) on users who upgraded into 22621.2428 not through 22621.2361 with EP installed. Updating into this version will redownload symbols due to changes in the way they are managed.
- 22621.2428 was just released to the general public, but symbols for twinui.pcshell.dll are not available at the time of writing. Despite that, StartDocked.dll and StartUI.dll are still the same as 22621.2361.
- I've also removed hardcoded and stuffed-together offsets of really old DLL versions to make the code more concise.
  • Loading branch information
Amrsatrio committed Oct 11, 2023
1 parent b52bd79 commit 8412bd6
Show file tree
Hide file tree
Showing 5 changed files with 615 additions and 1,154 deletions.
4 changes: 2 additions & 2 deletions ExplorerPatcher/StartMenu.c
Original file line number Diff line number Diff line change
Expand Up @@ -765,7 +765,7 @@ BOOL NeedsRo_PositionStartMenuForMonitor(
return TRUE;
}

DWORD GetStartMenuPosition(FARPROC SHRegGetValueFromHKCUHKLMFunc)
DWORD GetStartMenuPosition(t_SHRegGetValueFromHKCUHKLM SHRegGetValueFromHKCUHKLMFunc)
{
DWORD dwSize = sizeof(DWORD);

Expand All @@ -776,7 +776,7 @@ DWORD GetStartMenuPosition(FARPROC SHRegGetValueFromHKCUHKLMFunc)
SRRF_RT_REG_DWORD,
NULL,
&dwTaskbarAl,
(LPDWORD)(&dwSize)
&dwSize
) != ERROR_SUCCESS)
{
dwTaskbarAl = 1;
Expand Down
Loading

0 comments on commit 8412bd6

Please sign in to comment.