Make non-exported symbols static in dllmain.c #2940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR I made last year was too big. I changed everything practically. Some changes were maybe valid, some not, but there were too many. So here's a little one that has mildly bothered me for months and months now. Nearly all of the (far too numerous) symbols in dllmain.c are not actually used outside that file. They can be static. I've made it so.
I also added
voidto a few function declarations with no parameters because I'm neurotic like that and renamed the variableCodetodllCodebecause it hurt me to look at, but I somehow avoided the urge to change anything else that might break something. So this shouldn't break anything, probably. Doesn't really fix anything either though.