Add tests for Valkey 9.x#71
Merged
Merged
Conversation
Signed-off-by: hieu2102 <hieund2102@gmail.com>
Signed-off-by: hieu2102 <hieund2102@gmail.com>
Signed-off-by: hieu2102 <hieund2102@gmail.com>
Member
|
@hieu2102 by stop using the custom Dockerfile built each time, you'll stop running the tests using valkey-server with address sanitizer enabled, and as a consequence we might miss memory corruption errors. I'm not against this PR, I just want to make sure that everyone is aware of the difference of using the upstream image instead. |
| image: valkey/valkey:9.0 | ||
| working_dir: /valkey-ldap | ||
| command: valkey-server valkey.conf | ||
| profiles: ["valkey-8.1"] |
Collaborator
There was a problem hiding this comment.
Need to update to 9
| image: valkey/valkey:9.1 | ||
| working_dir: /valkey-ldap | ||
| command: valkey-server valkey.conf | ||
| profiles: ["valkey-8.1"] |
Collaborator
There was a problem hiding this comment.
need to update to 9.1
Signed-off-by: hieu2102 <hieund2102@gmail.com>
…are running Signed-off-by: hieu2102 <hieund2102@gmail.com>
Signed-off-by: hieu2102 <hieund2102@gmail.com>
Signed-off-by: hieu2102 <hieund2102@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
implement #64
docker-composeto use upstream images (valkey/valkey:.*) instead of building it each time the CI job run./script/run_integration_tests.sh->./scripts/run_integration_tests.sh)start_valkey_ldapscript, the script will exit after 5 minutes if all required containers are still not running