Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Client Introspection] Client Commands Extended Filtering #1466

Open
wants to merge 3 commits into
base: unstable
Choose a base branch
from

Conversation

sarthakaggarwal97
Copy link
Contributor

@sarthakaggarwal97 sarthakaggarwal97 commented Dec 20, 2024

In this PR, we introduce a support for few more filters for CLIENT LIST and CLIENT KILL commands. We introduce these new filters:

  1. SUBSCRIBED-PATTERN pattern the client must subscribe to
  2. SUBSCRIBED-CHANNEL channel the client must subscribe to
  3. SUBSCRIBED-SHARD-CHANNEL <shard channel the client must subscribe to>
  4. FLAGS Client must include this flag. This can be a string with bunch of flags present one after the other.
  5. NAME client name
  6. MIN-IDLE minimum idle time of the client

Partly Addresses: #668

@sarthakaggarwal97 sarthakaggarwal97 marked this pull request as ready for review December 20, 2024 16:59
@sarthakaggarwal97 sarthakaggarwal97 force-pushed the client-extended-filters branch 3 times, most recently from 094ee75 to e518d93 Compare December 20, 2024 19:49
Copy link

codecov bot commented Dec 20, 2024

Codecov Report

Attention: Patch coverage is 60.20408% with 39 lines in your changes missing coverage. Please review.

Project coverage is 70.91%. Comparing base (6a8f068) to head (91df97a).

Files with missing lines Patch % Lines
src/networking.c 60.20% 39 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           unstable    #1466      +/-   ##
============================================
+ Coverage     70.81%   70.91%   +0.10%     
============================================
  Files           120      120              
  Lines         65094    65189      +95     
============================================
+ Hits          46095    46230     +135     
+ Misses        18999    18959      -40     
Files with missing lines Coverage Δ
src/commands.def 100.00% <ø> (ø)
src/networking.c 87.64% <60.20%> (-1.11%) ⬇️

... and 20 files with indirect coverage changes

@sarthakaggarwal97 sarthakaggarwal97 force-pushed the client-extended-filters branch 2 times, most recently from 89e5c0b to f7ad3a7 Compare January 15, 2025 21:56
@zuiderkwast zuiderkwast added the major-decision-pending Major decision pending by TSC team label Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
major-decision-pending Major decision pending by TSC team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants