Add availability_zone to the HELLO response#1487
Merged
zuiderkwast merged 4 commits intovalkey-io:unstablefrom Jan 7, 2025
Merged
Add availability_zone to the HELLO response#1487zuiderkwast merged 4 commits intovalkey-io:unstablefrom
availability_zone to the HELLO response#1487zuiderkwast merged 4 commits intovalkey-io:unstablefrom
Conversation
zuiderkwast
reviewed
Dec 25, 2024
Contributor
zuiderkwast
left a comment
zuiderkwast
left a comment
There was a problem hiding this comment.
I like the idea but i think we should only include it if it's configured.
Signed-off-by: Rueian <rueiancsie@gmail.com>
zuiderkwast
approved these changes
Dec 26, 2024
Contributor
zuiderkwast
left a comment
zuiderkwast
left a comment
There was a problem hiding this comment.
@valkey-io/core-team please approve if you agree.
enjoy-binbin
approved these changes
Dec 26, 2024
Member
enjoy-binbin
left a comment
enjoy-binbin
left a comment
There was a problem hiding this comment.
LGTM, please also add a test, i think it can be fit in protocol.tcl
Signed-off-by: Rueian <rueiancsie@gmail.com>
Contributor
Author
Thanks for the direction but how about we add the test in the tracking.tcl? That is the only place I found that has tests for the HELLO command. |
Member
|
tracking.tcl seem odd, the test does not do anything close to tracking, i suggest we also move |
Signed-off-by: Rueian <rueiancsie@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## unstable #1487 +/- ##
============================================
- Coverage 70.86% 70.85% -0.02%
============================================
Files 119 119
Lines 64859 64863 +4
============================================
- Hits 45963 45959 -4
- Misses 18896 18904 +8
|
Contributor
Author
Updated. |
hwware
reviewed
Dec 27, 2024
Signed-off-by: Rueian <rueiancsie@gmail.com>
hwware
approved these changes
Dec 27, 2024
3 tasks
hpatro
reviewed
Jan 2, 2025
madolson
added
client-changes-needed
madolson
approved these changes
Jan 3, 2025
madolson
added
major-decision-approved
rueian
added a commit
to rueian/valkey-doc
that referenced
this pull request
Jan 7, 2025
This PR is for valkey-io/valkey#1487. Signed-off-by: Rueian <rueiancsie@gmail.com>
Contributor
Author
|
Thanks for all the reviewing. Here is the PR for doc changes: valkey-io/valkey-doc#207. |
zuiderkwast
added
the
release-notes
madolson
removed
the
needs-doc-pr
enjoy-binbin
added a commit
that referenced
this pull request
Jan 8, 2025
This PR is a followup for #1487. Signed-off-by: Rueian <rueiancsie@gmail.com> Co-authored-by: Binbin <binloveplay1314@qq.com>
zuiderkwast
pushed a commit
to valkey-io/valkey-doc
that referenced
this pull request
Jan 8, 2025
Documentation for valkey-io/valkey#1487. It includes the `availability_zone` field in the examples and has a note saying that the field will only be present when it is set in configs. Signed-off-by: Rueian <rueiancsie@gmail.com>
madolson
reviewed
Jan 8, 2025
kronwerk
pushed a commit
to kronwerk/valkey
that referenced
this pull request
Jan 27, 2025
It's inconvenient for client implementations to extract the `availability_zone` information from the `INFO` response. The `INFO` response contains a lot of information that a client implementation typically doesn't need. This PR adds the availability zone to the `HELLO` response. Clients usually already use the `HELLO` command for protocol negotiation and also get the server `version` and `role` from its response. To keep the `HELLO` response small, the field is only added if availability zone is configured. --------- Signed-off-by: Rueian <rueiancsie@gmail.com>
kronwerk
pushed a commit
to kronwerk/valkey
that referenced
this pull request
Jan 27, 2025
This PR is a followup for valkey-io#1487. Signed-off-by: Rueian <rueiancsie@gmail.com> Co-authored-by: Binbin <binloveplay1314@qq.com>
zuiderkwast
added a commit
that referenced
this pull request
Feb 10, 2025
We add it to HELLO response in #1487. --------- Signed-off-by: Binbin <binloveplay1314@qq.com> Co-authored-by: Viktor Söderqvist <viktor.soderqvist@est.tech>
xbasel
pushed a commit
to xbasel/valkey
that referenced
this pull request
Mar 27, 2025
…y-io#1695) We add it to HELLO response in valkey-io#1487. --------- Signed-off-by: Binbin <binloveplay1314@qq.com> Co-authored-by: Viktor Söderqvist <viktor.soderqvist@est.tech>
xbasel
pushed a commit
to xbasel/valkey
that referenced
this pull request
Mar 27, 2025
…y-io#1695) We add it to HELLO response in valkey-io#1487. --------- Signed-off-by: Binbin <binloveplay1314@qq.com> Co-authored-by: Viktor Söderqvist <viktor.soderqvist@est.tech>
murphyjacob4
pushed a commit
to enjoy-binbin/valkey
that referenced
this pull request
Apr 13, 2025
…y-io#1695) We add it to HELLO response in valkey-io#1487. --------- Signed-off-by: Binbin <binloveplay1314@qq.com> Co-authored-by: Viktor Söderqvist <viktor.soderqvist@est.tech>
enjoy-binbin
added a commit
to enjoy-binbin/valkey
that referenced
this pull request
Mar 11, 2026
…t commands `availability_zone` was added to the HELLO command in valkey-io#1487, and it was missing the reply schema and the test was wrongly marked with `logreqres:skip`. `availability-zone` was added to CLUSTER SHARDS and CLUSTER SLOTS commands in valkey-io#3156, and it was missing the reply schema. Signed-off-by: Binbin <binloveplay1314@qq.com>
zuiderkwast
pushed a commit
that referenced
this pull request
Mar 11, 2026
…3352) `availability_zone` was added to the HELLO command in #1487, and it was missing the reply schema and the test was wrongly marked with `logreqres:skip`. `availability-zone` was added to CLUSTER SHARDS and CLUSTER SLOTS commands in #3156, and it was missing the reply schema. --------- Signed-off-by: Binbin <binloveplay1314@qq.com>
JimB123
pushed a commit
that referenced
this pull request
Mar 19, 2026
…3352) `availability_zone` was added to the HELLO command in #1487, and it was missing the reply schema and the test was wrongly marked with `logreqres:skip`. `availability-zone` was added to CLUSTER SHARDS and CLUSTER SLOTS commands in #3156, and it was missing the reply schema. --------- Signed-off-by: Binbin <binloveplay1314@qq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's inconvenient for client implementations to extract the
availability_zoneinformation from theINFOresponse. TheINFOresponse contains a lot of information that a client implementation typically doesn't need.This PR adds the availability zone to the
HELLOresponse. Clients usually already use theHELLOcommand for protocol negotiation and also get the serverversionandrolefrom its response. To keep theHELLOresponse small, the field is only added if availability zone is configured.