Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add build folder to gitignore. #1488

Open
wants to merge 1 commit into
base: unstable
Choose a base branch
from
Open

Add build folder to gitignore. #1488

wants to merge 1 commit into from

Conversation

lipzhu
Copy link
Contributor

@lipzhu lipzhu commented Dec 26, 2024

Default cmake build folder in vscode is "cmake.buildDirectory": "${workspaceFolder}/build".

@rjd15372
Copy link
Contributor

For me it also makes sense to use the build directory for building valkey using cmake, which is the default directory for using cmake.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lipzhu @rjd15372