Adds support for running EVAL with different scripting engines
#1497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit creates a new unit for the scripting engine code by extracting the existing code from the functions unit. We're doing this refactor to prepare the code for runnning the `EVAL` command using different scripting engines. Signed-off-by: Ricardo Dias <[email protected]>
…eate library callback Instead of using C strings to return the errors that may be happen during the code parsing of a scripting engine, use `robj` strings. This commit also removes the `valkey_asprintf` function, since it's not used in any place anymore. Signed-off-by: Ricardo Dias <[email protected]>
Signed-off-by: Ricardo Dias <[email protected]>
Signed-off-by: Ricardo Dias <[email protected]>
Signed-off-by: Ricardo Dias <[email protected]>
Signed-off-by: Ricardo Dias <[email protected]>
rjd15372
force-pushed
the
eval-api-1261
branch
from
8ae2eb8 to
f0c2edc
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## unstable #1497 +/- ##
============================================
+ Coverage 70.86% 70.92% +0.05%
============================================
Files 119 122 +3
Lines 64852 65072 +220
============================================
+ Hits 45958 46150 +192
- Misses 18894 18922 +28
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: This PR sits on top of #1312 and therefore, it will be kept in draft mode until #1312 is merged.
In this PR re-implement the
EVALcommands (EVAL,EVALSHA,SCRIPT LOAD, etc...) to use the scripting engine infrastructure introduced in 6adef8e. This allowsEVALto run scripts using different scripting engines.This new implementation generalizes the module API for implementing scripting engines to work with both
FUNCTIONandEVALcommands.