Move coverity back to ubuntu 22 until test failures are fixed#1504
Merged
Conversation
Signed-off-by: Madelyn Olson <madelyneolson@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## unstable #1504 +/- ##
============================================
+ Coverage 70.82% 70.90% +0.08%
============================================
Files 119 120 +1
Lines 64689 64911 +222
============================================
+ Hits 45815 46025 +210
- Misses 18874 18886 +12 |
enjoy-binbin
approved these changes
Jan 3, 2025
madolson
added a commit
that referenced
this pull request
Jan 7, 2025
This commit, #1504, moved the wrong worker to ubuntu 22. We wanted to move codecov and not coverity. Signed-off-by: Madelyn Olson <madelyneolson@gmail.com>
kronwerk
pushed a commit
to kronwerk/valkey
that referenced
this pull request
Jan 27, 2025
…-io#1504) The issues in valkey-io#1453 seem to have only shown up since we moved to ubuntu 24, as part of the rolling `ubunut-latest` migration from 22->24. Closes valkey-io#1453. Signed-off-by: Madelyn Olson <madelyneolson@gmail.com>
kronwerk
pushed a commit
to kronwerk/valkey
that referenced
this pull request
Jan 27, 2025
This commit, valkey-io#1504, moved the wrong worker to ubuntu 22. We wanted to move codecov and not coverity. Signed-off-by: Madelyn Olson <madelyneolson@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The issues in #1453 seem to have only shown up since we moved to ubuntu 24, as part of the rolling
ubunut-latestmigration from 22->24.