Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Vocalis and zathura, Handbrake is now GTK4 #278

Merged
merged 7 commits into from
Jan 12, 2025
Merged

Add Vocalis and zathura, Handbrake is now GTK4 #278

merged 7 commits into from
Jan 12, 2025

Conversation

GerryT11
Copy link
Contributor

No description provided.

@GerryT11
Sorted "Document Viewers" alphabetically
38cedfe
@GerryT11
Add zathura
3768d2d 
zathura - Customizable and functional document viewer with support for PDF, PostScript, DjVu and comic book 

`#c` `#gtk3`.

https://pwmt.org/projects/zathura
https://github.com/pwmt/zathura
@GerryT11
Handbrake is now GTK 4
de041d4 
Since version 1.8 Handbrake is now GTK4: "Migrated the UI to GTK 4" (released May 20, 2024)

https://github.com/HandBrake/HandBrake/releases
@GerryT11
Add Vocalis
c60f42d 
Vocalis - Sound recorder for the GNOME desktop 

`#gjs` `#gtk4` `#libadwaita`.

https://gitlab.gnome.org/World/vocalis
@GerryT11
Copy link
Contributor Author

Hi @loicreynier , did you miss this one here? The pull request (from about two weeks ago) adds two applications (zathura, Vocalis). Or was there a problem with my commit not getting through, or just no time yet?

@loicreynier
Copy link
Collaborator

Hi @GerryT11, I left a review with some suggestions that you might have missed. Could you take a look when you have a moment?

@GerryT11
Copy link
Contributor Author

Hi @loicreynier , I don't see the suggestions here, neither in the pull request nor the individual comments. Do you see them?
They are probably good and I agree without having seen them :-)

loicreynier
loicreynier requested changes Jan 12, 2025
View reviewed changes
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@loicreynier loicreynier merged commit 93ce090 into valpackett:trunk Jan 12, 2025
1 check passed
@loicreynier
Copy link
Collaborator

Hi @loicreynier , I don't see the suggestions here, neither in the pull request nor the individual comments. Do you see them? They are probably good and I agree without having seen them :-)

Apologies, I realized I hadn't submitted the review, so the comments were only visible to me. Thanks for submitting the PR!

@GerryT11
Copy link
Contributor Author

Thanks! Bonne nouvellle année 2025!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loicreynier loicreynier loicreynier requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GerryT11 @loicreynier