Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Dynamic DeepHit (time-to-event) #39

Merged
merged 61 commits into from
Mar 22, 2023
Merged

Conversation

DrShushen
Copy link
Member

@DrShushen DrShushen commented Mar 21, 2023

Description

Closes #22

  • Add DynamicDeepHitTimeToEventAnalysis and the infrastructure and models needed for that.
  • Add time-to-event evaluation and benchmarking.

Separately:

  • Make data loaders subclass DataLoader class.
  • Rename some things to ensure consistent naming for the time-to-event concept.
  • Remove some unused legacy code.
  • Some additional data transformation helper.

Affected Dependencies

scikit-learn added.

How has this been tested?

  • See tests, new additions all covered.

Checklist

@DrShushen DrShushen added the enhancement New feature or request label Mar 21, 2023
@DrShushen DrShushen requested a review from bcebere March 21, 2023 20:43
@DrShushen DrShushen self-assigned this Mar 21, 2023
@DrShushen
Copy link
Member Author

There are still some additional metrics that need to be added as per #9 - will add that in future PR

Copy link
Contributor

@bcebere bcebere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! LGTM!

There is a discussion about time-to-event naming: There is dedicated literature for time-to-event regression, which approximates the date of the event. And is different from the current models you have.

Otherwise, survival models approximate the probability of risk(class 1) or survival(class 0) for multiple horizons. In AutoPrognosis I am approximating the probability of risk(same as here), so these models are named risk_estimation models.

So, it should be clear that you don't approximate the date of the event, neither the survival probability. But the risk probability.

@bcebere bcebere merged commit 60e8496 into main Mar 22, 2023
@bcebere bcebere deleted the DrShushen/add-survival-DDH branch March 22, 2023 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feat] Prediction models: Add Dynamic DeepHit
2 participants