-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Testing #14
base: dev
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi dear student,
Good job so far!
You still need to work on some issues to prepare your project for the final evaluation, but you are almost there!
Suggested changes
Check the comments under the review.
You can use as many of my suggestions as you want. If there is anything you would like to skip - feel free to do that. However, I strongly recommend you to take them into account as they can make your code better._
- It looks like you have some issues with the snapshots tests, I invite you to fix this or remove it (this because the required tests are the unit only)
Snapshot Summary
› 3 snapshots failed from 3 test suites. Inspect your code changes or press `u` to update them.
Test Suites: 3 failed, 4 passed, 7 total
Tests: 3 failed, 4 passed, 7 total
Snapshots: 3 failed, 4 passed, 7 total
- Please try to add more tests, unit test are important when you have the plan to increment a project size (I understand this is not the idea but, this could help to understand this important part even better).
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
In this pull request, I have created these tests